From 570c17a3b85da8b38ae823697a5f71f899f4747e Mon Sep 17 00:00:00 2001 From: Tim Allclair Date: Mon, 16 Oct 2017 11:16:21 -0700 Subject: [PATCH 1/4] Create api-{approvers,reviewers} alias --- OWNERS_ALIASES | 45 ++++++++++++++++++++++++++- api/OWNERS | 44 ++------------------------ docs/api-reference/OWNERS | 4 +++ pkg/api/OWNERS | 44 ++------------------------ staging/src/k8s.io/api/OWNERS | 50 +++--------------------------- staging/src/k8s.io/api/core/OWNERS | 42 ++----------------------- 6 files changed, 59 insertions(+), 170 deletions(-) create mode 100644 docs/api-reference/OWNERS diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index 9662e4677d..0924c90b10 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -175,4 +175,47 @@ aliases: - radhikpac - jpbetz - cmluciano - + api-approvers: + - erictune + - lavalamp + - smarterclayton + - thockin + - liggitt + # - bgrant0607 # manual escalations only + api-reviewers: + - erictune + - lavalamp + - smarterclayton + - thockin + - liggitt + - wojtek-t + - deads2k + - yujuhong + - brendandburns + - derekwaynecarr + - caesarxuchao + - vishh + - mikedanese + - nikhiljindal + - gmarek + - davidopp + - pmorie + - sttts + - dchen1107 + - saad-ali + - zmerlynn + - luxas + - janetkuo + - justinsb + - pwittrock + - roberthbailey + - ncdc + - tallclair + - yifan-gu + - eparis + - mwielgus + - timothysc + - soltysh + - piosz + - jsafrane + - jbeda diff --git a/api/OWNERS b/api/OWNERS index 4d61bb354e..8f7783f9f0 100644 --- a/api/OWNERS +++ b/api/OWNERS @@ -1,44 +1,4 @@ approvers: -- erictune -- lavalamp -- smarterclayton -- thockin -- liggitt -# - bgrant0607 # manual escalations only +- api-approvers reviewers: -- thockin -- lavalamp -- smarterclayton -- wojtek-t -- deads2k -- yujuhong -- brendandburns -- derekwaynecarr -- caesarxuchao -- vishh -- mikedanese -- liggitt -- nikhiljindal -- gmarek -- erictune -- davidopp -- pmorie -- sttts -- dchen1107 -- saad-ali -- zmerlynn -- luxas -- janetkuo -- justinsb -- pwittrock -- roberthbailey -- ncdc -- tallclair -- yifan-gu -- eparis -- mwielgus -- timothysc -- soltysh -- piosz -- jsafrane -- jbeda +- api-reviewers diff --git a/docs/api-reference/OWNERS b/docs/api-reference/OWNERS new file mode 100644 index 0000000000..8f7783f9f0 --- /dev/null +++ b/docs/api-reference/OWNERS @@ -0,0 +1,4 @@ +approvers: +- api-approvers +reviewers: +- api-reviewers diff --git a/pkg/api/OWNERS b/pkg/api/OWNERS index 0605b27b2a..8f7783f9f0 100644 --- a/pkg/api/OWNERS +++ b/pkg/api/OWNERS @@ -1,44 +1,4 @@ approvers: -- erictune -- lavalamp -- smarterclayton -- thockin -- liggitt -# - bgrant0607 # manual escalations only +- api-approvers reviewers: -- thockin -- lavalamp -- smarterclayton -- wojtek-t -- deads2k -- yujuhong -- brendandburns -- derekwaynecarr -- caesarxuchao -- vishh -- mikedanese -- liggitt -- nikhiljindal -- gmarek -- erictune -- davidopp -- pmorie -- sttts -- dchen1107 -- saad-ali -- zmerlynn -- luxas -- janetkuo -- justinsb -- pwittrock -- roberthbailey -- ncdc -- tallclair -- yifan-gu -- eparis -- mwielgus -- timothysc -- soltysh -- piosz -- jsafrane -- jbeda +- api-reviewers diff --git a/staging/src/k8s.io/api/OWNERS b/staging/src/k8s.io/api/OWNERS index 918b10522c..43ba49c4b5 100644 --- a/staging/src/k8s.io/api/OWNERS +++ b/staging/src/k8s.io/api/OWNERS @@ -1,51 +1,11 @@ approvers: -- erictune -- lavalamp -- smarterclayton -- thockin -- liggitt -# - bgrant0607 # manual escalations only +- api-approvers reviewers: -- brendandburns -- caesarxuchao -- davidopp -- dchen1107 -- deads2k -- derekwaynecarr -- dims -- eparis -- erictune -- errordeveloper -- feiskyer -- gmarek -- janetkuo -- jbeda -- jsafrane +- api-reviewers - jszczepkowski -- justinsb +- errordeveloper - krousey -- lavalamp -- liggitt -- luxas +- feiskyer +- dims - madhusudancs -- mikedanese -- mwielgus -- ncdc -- nikhiljindal -- piosz -- pmorie -- pwittrock -- roberthbailey - rootfs -- saad-ali -- smarterclayton -- soltysh -- sttts -- tallclair -- thockin -- timothysc -- vishh -- wojtek-t -- yifan-gu -- yujuhong -- zmerlynn diff --git a/staging/src/k8s.io/api/core/OWNERS b/staging/src/k8s.io/api/core/OWNERS index 7009d88bf1..8f7783f9f0 100644 --- a/staging/src/k8s.io/api/core/OWNERS +++ b/staging/src/k8s.io/api/core/OWNERS @@ -1,42 +1,4 @@ approvers: -- erictune -- lavalamp -- smarterclayton -- thockin +- api-approvers reviewers: -- thockin -- lavalamp -- smarterclayton -- wojtek-t -- deads2k -- yujuhong -- brendandburns -- derekwaynecarr -- caesarxuchao -- vishh -- mikedanese -- liggitt -- nikhiljindal -- gmarek -- erictune -- davidopp -- pmorie -- sttts -- dchen1107 -- saad-ali -- zmerlynn -- luxas -- janetkuo -- justinsb -- pwittrock -- roberthbailey -- ncdc -- tallclair -- yifan-gu -- eparis -- mwielgus -- timothysc -- soltysh -- piosz -- jsafrane -- jbeda +- api-reviewers From 562b7e5f85e82798d35912a8729c402842b18a27 Mon Sep 17 00:00:00 2001 From: Tim Allclair Date: Wed, 18 Oct 2017 11:15:08 -0700 Subject: [PATCH 2/4] Ignore OWNERS files in hack/verify-api-reference-docs.sh --- hack/verify-api-reference-docs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hack/verify-api-reference-docs.sh b/hack/verify-api-reference-docs.sh index ec1dca6991..e41256f9c9 100755 --- a/hack/verify-api-reference-docs.sh +++ b/hack/verify-api-reference-docs.sh @@ -36,7 +36,7 @@ trap "rm -rf ${TMP_ROOT}" EXIT SIGINT echo "diffing ${API_REFERENCE_DOCS_ROOT} against freshly generated docs" ret=0 -diff -NauprB -I 'Last update' --exclude=*.md "${API_REFERENCE_DOCS_ROOT}" "${OUTPUT_DIR}" || ret=$? +diff -NauprB -I 'Last update' --exclude=*.md --exclude=OWNERS "${API_REFERENCE_DOCS_ROOT}" "${OUTPUT_DIR}" || ret=$? if [[ $ret -eq 0 ]] then echo "${API_REFERENCE_DOCS_ROOT} up to date." From 858cfc6ceaa83fd046a35d902114e64127d2add5 Mon Sep 17 00:00:00 2001 From: Tim Allclair Date: Wed, 18 Oct 2017 12:12:38 -0700 Subject: [PATCH 3/4] Remove redundant staging/src/k8s.io/api/core/OWNERS --- staging/src/k8s.io/api/core/OWNERS | 4 ---- 1 file changed, 4 deletions(-) delete mode 100644 staging/src/k8s.io/api/core/OWNERS diff --git a/staging/src/k8s.io/api/core/OWNERS b/staging/src/k8s.io/api/core/OWNERS deleted file mode 100644 index 8f7783f9f0..0000000000 --- a/staging/src/k8s.io/api/core/OWNERS +++ /dev/null @@ -1,4 +0,0 @@ -approvers: -- api-approvers -reviewers: -- api-reviewers From 83fd943cfc3decf98475c74f8590810b8517dce9 Mon Sep 17 00:00:00 2001 From: Tim Allclair Date: Thu, 19 Oct 2017 14:28:23 -0700 Subject: [PATCH 4/4] restore staging api owners --- staging/src/k8s.io/api/OWNERS | 52 +++++++++++++++++++++++++++++++---- 1 file changed, 46 insertions(+), 6 deletions(-) diff --git a/staging/src/k8s.io/api/OWNERS b/staging/src/k8s.io/api/OWNERS index 43ba49c4b5..918b10522c 100644 --- a/staging/src/k8s.io/api/OWNERS +++ b/staging/src/k8s.io/api/OWNERS @@ -1,11 +1,51 @@ approvers: -- api-approvers +- erictune +- lavalamp +- smarterclayton +- thockin +- liggitt +# - bgrant0607 # manual escalations only reviewers: -- api-reviewers -- jszczepkowski -- errordeveloper -- krousey -- feiskyer +- brendandburns +- caesarxuchao +- davidopp +- dchen1107 +- deads2k +- derekwaynecarr - dims +- eparis +- erictune +- errordeveloper +- feiskyer +- gmarek +- janetkuo +- jbeda +- jsafrane +- jszczepkowski +- justinsb +- krousey +- lavalamp +- liggitt +- luxas - madhusudancs +- mikedanese +- mwielgus +- ncdc +- nikhiljindal +- piosz +- pmorie +- pwittrock +- roberthbailey - rootfs +- saad-ali +- smarterclayton +- soltysh +- sttts +- tallclair +- thockin +- timothysc +- vishh +- wojtek-t +- yifan-gu +- yujuhong +- zmerlynn