From c215966d2248675e13616310273de22b947c5baa Mon Sep 17 00:00:00 2001
From: danielqsj <qsj.daniel@gmail.com>
Date: Thu, 31 Jan 2019 22:51:20 +0800
Subject: [PATCH 1/2] fix shellcheck failure in etcd shell

---
 hack/.shellcheck_failures |  2 --
 hack/install-etcd.sh      |  2 +-
 hack/lib/etcd.sh          | 12 ++++++++----
 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures
index 64d0a1d99b..9f54b22d3c 100644
--- a/hack/.shellcheck_failures
+++ b/hack/.shellcheck_failures
@@ -40,13 +40,11 @@
 ./hack/godep-restore.sh
 ./hack/godep-save.sh
 ./hack/grab-profiles.sh
-./hack/install-etcd.sh
 ./hack/jenkins/benchmark-dockerized.sh
 ./hack/jenkins/build.sh
 ./hack/jenkins/test-dockerized.sh
 ./hack/jenkins/upload-to-gcs.sh
 ./hack/jenkins/verify-dockerized.sh
-./hack/lib/etcd.sh
 ./hack/lib/golang.sh
 ./hack/lib/init.sh
 ./hack/lib/logging.sh
diff --git a/hack/install-etcd.sh b/hack/install-etcd.sh
index 3f5961a536..f66562cd2c 100755
--- a/hack/install-etcd.sh
+++ b/hack/install-etcd.sh
@@ -21,7 +21,7 @@ set -o errexit
 set -o nounset
 set -o pipefail
 
-KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
+KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
 source "${KUBE_ROOT}/hack/lib/init.sh"
 
 kube::etcd::install
diff --git a/hack/lib/etcd.sh b/hack/lib/etcd.sh
index 17f5581001..97b1ace0c5 100755
--- a/hack/lib/etcd.sh
+++ b/hack/lib/etcd.sh
@@ -16,6 +16,10 @@
 
 # A set of helpers for starting/running etcd for tests
 
+set -o errexit
+set -o nounset
+set -o pipefail
+
 ETCD_VERSION=${ETCD_VERSION:-3.3.10}
 ETCD_HOST=${ETCD_HOST:-127.0.0.1}
 ETCD_PORT=${ETCD_PORT:-2379}
@@ -41,18 +45,18 @@ kube::etcd::validate() {
   fi
   if ${port_check_command} -nat | grep "LISTEN" | grep "[\.:]${ETCD_PORT:?}" >/dev/null 2>&1; then
     kube::log::usage "unable to start etcd as port ${ETCD_PORT} is in use. please stop the process listening on this port and retry."
-    kube::log::usage "`netstat -nat | grep "[\.:]${ETCD_PORT:?} .*LISTEN"`"
+    kube::log::usage "$(netstat -nat | grep "[\.:]${ETCD_PORT:?} .*LISTEN")"
     exit 1
   fi
 
   # validate installed version is at least equal to minimum
   version=$(etcd --version | tail -n +1 | head -n 1 | cut -d " " -f 3)
-  if [[ $(kube::etcd::version ${ETCD_VERSION}) -gt $(kube::etcd::version ${version}) ]]; then
+  if [[ $(kube::etcd::version "${ETCD_VERSION}") -gt $(kube::etcd::version "${version}") ]]; then
    export PATH=${KUBE_ROOT}/third_party/etcd:${PATH}
    hash etcd
    echo "${PATH}"
    version=$(etcd --version | head -n 1 | cut -d " " -f 3)
-   if [[ $(kube::etcd::version ${ETCD_VERSION}) -gt $(kube::etcd::version ${version}) ]]; then
+   if [[ $(kube::etcd::version "${ETCD_VERSION}") -gt $(kube::etcd::version "${version}") ]]; then
     kube::log::usage "etcd version ${ETCD_VERSION} or greater required."
     kube::log::info "You can use 'hack/install-etcd.sh' to install a copy in third_party/."
     exit 1
@@ -76,7 +80,7 @@ kube::etcd::start() {
     ETCD_LOGFILE=${ETCD_LOGFILE:-"/dev/null"}
   fi
   kube::log::info "etcd --advertise-client-urls ${KUBE_INTEGRATION_ETCD_URL} --data-dir ${ETCD_DIR} --listen-client-urls http://${ETCD_HOST}:${ETCD_PORT} --debug > \"${ETCD_LOGFILE}\" 2>/dev/null"
-  etcd --advertise-client-urls ${KUBE_INTEGRATION_ETCD_URL} --data-dir ${ETCD_DIR} --listen-client-urls ${KUBE_INTEGRATION_ETCD_URL} --debug 2> "${ETCD_LOGFILE}" >/dev/null &
+  etcd --advertise-client-urls "${KUBE_INTEGRATION_ETCD_URL}" --data-dir "${ETCD_DIR}" --listen-client-urls "${KUBE_INTEGRATION_ETCD_URL}" --debug 2> "${ETCD_LOGFILE}" >/dev/null &
   ETCD_PID=$!
 
   echo "Waiting for etcd to come up."

From e698682a0e610b6d94367f870c13ecd795cce631 Mon Sep 17 00:00:00 2001
From: danielqsj <qsj.daniel@gmail.com>
Date: Sun, 24 Feb 2019 20:12:53 +0800
Subject: [PATCH 2/2] change a way to pass SC2164 in etcd.sh

---
 hack/lib/etcd.sh | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/hack/lib/etcd.sh b/hack/lib/etcd.sh
index 97b1ace0c5..79821e7d9d 100755
--- a/hack/lib/etcd.sh
+++ b/hack/lib/etcd.sh
@@ -16,10 +16,6 @@
 
 # A set of helpers for starting/running etcd for tests
 
-set -o errexit
-set -o nounset
-set -o pipefail
-
 ETCD_VERSION=${ETCD_VERSION:-3.3.10}
 ETCD_HOST=${ETCD_HOST:-127.0.0.1}
 ETCD_PORT=${ETCD_PORT:-2379}
@@ -114,7 +110,7 @@ kube::etcd::install() {
     os=$(kube::util::host_os)
     arch=$(kube::util::host_arch)
 
-    cd "${KUBE_ROOT}/third_party"
+    cd "${KUBE_ROOT}/third_party" || return 1
     if [[ $(readlink etcd) == etcd-v${ETCD_VERSION}-${os}-* ]]; then
       kube::log::info "etcd v${ETCD_VERSION} already installed at path:"
       kube::log::info "$(pwd)/$(readlink etcd)"