Browse Source

Merge pull request #1754 from briandowns/add_pr_template

add pull request template
pull/2096/head
Brian Downs 4 years ago committed by GitHub
parent
commit
6fcec6aea9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 45
      .github/PULL_REQUEST_TEMPLATE.md
  2. 2
      BUILDING.md

45
.github/PULL_REQUEST_TEMPLATE.md

@ -0,0 +1,45 @@
<!-- HTML Comments can be left in place or removed, dealers choice. They are present simply to guide you on your pull-request journey. -->
Proposed changes
======
<!--
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
-->
Types of changes
======
<!--
What types of changes does your code introduce to Rancher?
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
-->
Verification
======
<!--
How can the changes be verified? Please provide whatever additional information necessary to help verify the proposed changes.
-->
Linked Issues
======
<!--
Link any related issues, pull-requests, or commit hashes that are relavent to this pull request.
If you are opening a PR without a corresponding issue please consider creating one first, [here](https://github.com/rancher/k3s/issues). A functional example will greatly help QA with verifying/reproducing a bug or testing new features.
-->
Further comments
======
<!--
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
-->

2
BUILDING.md

@ -10,7 +10,7 @@ This repo includes all of Kubernetes history so `--depth 1` will avoid most of t
To build the full release binary run `make` and that will create `./dist/artifacts/k3s`.
Optionally to build the binaries using local go environment without running linting or building docker images:
Optionally to build the binaries using local Go environment without running linting or building docker images:
```bash
./scripts/download && ./scripts/build && ./scripts/package-cli

Loading…
Cancel
Save