From 84bab0dae5dda80ca515272a2894884ebc6d91c2 Mon Sep 17 00:00:00 2001
From: Justin Santa Barbara <justin@fathomdb.com>
Date: Fri, 6 Nov 2015 10:39:42 -0500
Subject: [PATCH] AWS: kube-down was failing with no instances

The new delete-ASG logic wasn't correct if there were no instances
---
 cluster/aws/util.sh | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/cluster/aws/util.sh b/cluster/aws/util.sh
index 627b798d45..c93b529fc6 100755
--- a/cluster/aws/util.sh
+++ b/cluster/aws/util.sh
@@ -1204,21 +1204,21 @@ function kube-down {
                                       Name=tag:KubernetesCluster,Values=${CLUSTER_ID} \
                             --query Reservations[].Instances[].InstanceId)
 
-    asg_groups=$($AWS_CMD   --output text describe-instances \
-                            --query 'Reservations[].Instances[].Tags[?Key==`aws:autoscaling:groupName`].Value[]' \
-                            --instance-ids ${instance_ids})
-    for asg_group in ${asg_groups}; do
-      if [[ -n $(${AWS_ASG_CMD} --output text describe-auto-scaling-groups --auto-scaling-group-names ${asg_group} --query AutoScalingGroups[].AutoScalingGroupName) ]]; then
-        echo "Deleting auto-scaling group: ${asg_group}"
-        ${AWS_ASG_CMD} delete-auto-scaling-group --force-delete --auto-scaling-group-name ${asg_group}
-      fi
-      if [[ -n $(${AWS_ASG_CMD} --output text describe-launch-configurations --launch-configuration-names ${asg_group} --query LaunchConfigurations[].LaunchConfigurationName) ]]; then
-        echo "Deleting auto-scaling launch configuration: ${asg_group}"
-        ${AWS_ASG_CMD} delete-launch-configuration --launch-configuration-name ${asg_group}
-      fi
-    done
-
     if [[ -n "${instance_ids}" ]]; then
+      asg_groups=$($AWS_CMD   --output text describe-instances \
+                              --query 'Reservations[].Instances[].Tags[?Key==`aws:autoscaling:groupName`].Value[]' \
+                              --instance-ids ${instance_ids})
+      for asg_group in ${asg_groups}; do
+        if [[ -n $(${AWS_ASG_CMD} --output text describe-auto-scaling-groups --auto-scaling-group-names ${asg_group} --query AutoScalingGroups[].AutoScalingGroupName) ]]; then
+          echo "Deleting auto-scaling group: ${asg_group}"
+          ${AWS_ASG_CMD} delete-auto-scaling-group --force-delete --auto-scaling-group-name ${asg_group}
+        fi
+        if [[ -n $(${AWS_ASG_CMD} --output text describe-launch-configurations --launch-configuration-names ${asg_group} --query LaunchConfigurations[].LaunchConfigurationName) ]]; then
+          echo "Deleting auto-scaling launch configuration: ${asg_group}"
+          ${AWS_ASG_CMD} delete-launch-configuration --launch-configuration-name ${asg_group}
+        fi
+      done
+
       $AWS_CMD terminate-instances --instance-ids ${instance_ids} > $LOG
       echo "Waiting for instances to be deleted"
       while true; do