From b6e1fecde7f43f8a0284b56c291fd7fa08391ea1 Mon Sep 17 00:00:00 2001 From: zouyee Date: Tue, 19 Dec 2017 23:24:35 +0800 Subject: [PATCH] check function return err --- pkg/volume/cephfs/cephfs.go | 6 +++++- pkg/volume/glusterfs/glusterfs.go | 5 +++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/pkg/volume/cephfs/cephfs.go b/pkg/volume/cephfs/cephfs.go index bbe681d71b..103766e7e2 100644 --- a/pkg/volume/cephfs/cephfs.go +++ b/pkg/volume/cephfs/cephfs.go @@ -232,7 +232,10 @@ func (cephfsVolume *cephfsMounter) SetUpAt(dir string, fsGroup *int64) error { if !notMnt { return nil } - os.MkdirAll(dir, 0750) + + if err := os.MkdirAll(dir, 0750); err != nil { + return err + } // check whether it belongs to fuse, if not, default to use kernel mount. if cephfsVolume.checkFuseMount() { @@ -253,6 +256,7 @@ func (cephfsVolume *cephfsMounter) SetUpAt(dir string, fsGroup *int64) error { } } glog.V(4).Infof("CephFS kernel mount.") + err = cephfsVolume.execMount(dir) if err != nil { // cleanup upon failure. diff --git a/pkg/volume/glusterfs/glusterfs.go b/pkg/volume/glusterfs/glusterfs.go index d90ea04cb7..6e3c4545fb 100644 --- a/pkg/volume/glusterfs/glusterfs.go +++ b/pkg/volume/glusterfs/glusterfs.go @@ -259,8 +259,9 @@ func (b *glusterfsMounter) SetUpAt(dir string, fsGroup *int64) error { if !notMnt { return nil } - - os.MkdirAll(dir, 0750) + if err := os.MkdirAll(dir, 0750); err != nil { + return err + } err = b.setUpAtInternal(dir) if err == nil { return nil