Fix cronjob panic on status update failure

2017-02-17 11:29:39 -08:00 · 2017-02-17 11:29:39 -08:00 · 6753544949
parent 68814c0203
commit 6753544949
1 changed files with 1 additions and 0 deletions
--- a/pkg/controller/cronjob/cronjob_controller.go
+++ b/pkg/controller/cronjob/cronjob_controller.go
@ -167,6 +167,7 @@ func SyncOne(sj batch.CronJob, js []batch.Job, now time.Time, jc jobControlInter
 	updatedSJ, err := sjc.UpdateStatus(&sj)
 	if err != nil {
 		glog.Errorf("Unable to update status for %s (rv = %s): %v", nameForLog, sj.ResourceVersion, err)
+		return
 	}
 	sj = *updatedSJ