Merge pull request #74400 from rojkov/kubeadm-refactor-etcdClient

kubeadm: simplify creating etcdClient
pull/564/head
Kubernetes Prow Robot 2019-02-22 19:19:16 -08:00 committed by GitHub
commit 65cdd7e74a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 10 deletions

View File

@ -98,23 +98,18 @@ func runPlan(flags *planFlags, userVersion string) error {
// external etcd vs static pod etcd
isExternalEtcd := cfg.Etcd.External != nil
if isExternalEtcd {
client, err := etcdutil.New(
etcdClient, err = etcdutil.New(
cfg.Etcd.External.Endpoints,
cfg.Etcd.External.CAFile,
cfg.Etcd.External.CertFile,
cfg.Etcd.External.KeyFile)
if err != nil {
return err
}
etcdClient = client
} else {
// Connects to local/stacked etcd existing in the cluster
client, err := etcdutil.NewFromCluster(client, cfg.CertificatesDir)
etcdClient, err = etcdutil.NewFromCluster(client, cfg.CertificatesDir)
}
if err != nil {
return err
}
etcdClient = client
}
// Compute which upgrade possibilities there are
klog.V(1).Infof("[upgrade/plan] computing upgrade possibilities")