github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

proxy/userspace: add dcbw and danwinship to OWNERS approvers 

Per recommendation of @thockin:

https://github.com/kubernetes/kubernetes/pull/71735#pullrequestreview-189515580

---
IMO this code is as dead as it could be. The only significant user is OpenShift as far as I know. I'd rather never touch it again, but I know that is not realistic.

Also, it seems like maybe this could be broken into a couple commits for easier review?

I raised some questions about this design, but I think you should add yourselves as approvers in OWNERS for this subdir. If it evolves, I will lose context on the impl. I don't think it is covered by e2e, either (more argument for breaking it to a separate repo and having its own e2e tests)
---
k3s-v1.15.3
Dan Williams 2019-04-08 12:38:22 -05:00
parent 8a2f8e69ed
commit 63c01133f8
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/proxy/userspace/OWNERS
View File

@ -1,9 +1,15 @@
# See the OWNERS docs at https://go.k8s.io/owners # See the OWNERS docs at https://go.k8s.io/owners
approvers:
- thockin
- dcbw
- danwinship
reviewers: reviewers:
- thockin - thockin
- lavalamp - lavalamp
- smarterclayton - smarterclayton
- freehan - freehan
- dcbw
- danwinship
labels: labels:
- sig/network - sig/network