From 6317da01e506090f0a269f8351b688b59af0283b Mon Sep 17 00:00:00 2001
From: Erik Wilson <Erik.E.Wilson@gmail.com>
Date: Fri, 24 Jan 2020 10:42:34 -0700
Subject: [PATCH] Enforce that tag versions are prefixed with k8s go.mod
 version

---
 scripts/test-helpers | 3 +--
 scripts/version.sh   | 8 ++++++--
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/scripts/test-helpers b/scripts/test-helpers
index 97eac7c795..060cc39e15 100755
--- a/scripts/test-helpers
+++ b/scripts/test-helpers
@@ -189,12 +189,11 @@ sonobuoy-test() {
         return 0
     fi
     echo 'Starting sonobuoy tests'
-    local conformanceVersion=$(sed -e 's/[-+].*$//g' <<< "$VERSION_K8S")
 
     sonobuoy run \
         --config=scripts/sonobuoy-config.json \
         --plugin-env=e2e.E2E_USE_GO_RUNNER=true \
-        --kube-conformance-image-version=${conformanceVersion} \
+        --kube-conformance-image-version=${VERSION_K8S} \
         --wait=30 \
         $@ &
 
diff --git a/scripts/version.sh b/scripts/version.sh
index f81c3f9139..57ff0da2b1 100755
--- a/scripts/version.sh
+++ b/scripts/version.sh
@@ -26,7 +26,7 @@ if [ -z "$VERSION_CRICTL" ]; then
     VERSION_CRICTL="v0.0.0"
 fi
 
-VERSION_K8S=$(grep k8s.io/kubernetes go.mod | head -n1 | awk '{print $4}')
+VERSION_K8S=$(grep k8s.io/kubernetes go.mod | head -n1 | awk '{print $4}' | sed -e 's/[-+].*//')
 if [ -z "$VERSION_K8S" ]; then
     VERSION_K8S="v0.0.0"
 fi
@@ -34,8 +34,12 @@ fi
 VERSION_CNIPLUGINS="v0.7.6-k3s1"
 
 if [[ -n "$GIT_TAG" ]]; then
+    if [[ ! "$GIT_TAG" =~ ^"$VERSION_K8S"[+-] ]]; then
+        echo "Tagged version '$GIT_TAG' does not match expected version '$VERSION_K8S[+-]*'" >&2
+        exit 1
+    fi
     VERSION=$GIT_TAG
 else
-    VERSION="$(sed -e 's/[-+].*//' <<< "$VERSION_K8S")+${COMMIT:0:8}$DIRTY"
+    VERSION="$VERSION_K8S+${COMMIT:0:8}$DIRTY"
 fi
 VERSION_TAG="$(sed -e 's/+/-/g' <<< "$VERSION")"