From 61b35caf38c647101df3164f00d10ab96f00c8f5 Mon Sep 17 00:00:00 2001 From: Xing Yang Date: Thu, 25 Apr 2019 12:48:25 -0700 Subject: [PATCH] Update rbac rule for external-snapshotter e2e test In the DeleteVolumeFinalizer feature in external-snapshotter, the external-snapshotter needs to update the PVC object to add a Finalizer if a snapshot is being created from the PVC and delete the Finalizer after the snapshot is created. For that reason, we need to add "update" rbac rule for the PVC object in external-snapshot e2e test manifest file. DeleteVolumeFinalizer PR is here. It couldn't pass e2e test until we fix the rbac rule in e2e. https://github.com/kubernetes-csi/external-snapshotter/pull/47 --- .../storage-csi/external-snapshotter/rbac.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/e2e/testing-manifests/storage-csi/external-snapshotter/rbac.yaml b/test/e2e/testing-manifests/storage-csi/external-snapshotter/rbac.yaml index f29db31928..91b56df66e 100644 --- a/test/e2e/testing-manifests/storage-csi/external-snapshotter/rbac.yaml +++ b/test/e2e/testing-manifests/storage-csi/external-snapshotter/rbac.yaml @@ -25,7 +25,7 @@ rules: verbs: ["get", "list", "watch"] - apiGroups: [""] resources: ["persistentvolumeclaims"] - verbs: ["get", "list", "watch"] + verbs: ["get", "list", "watch", "update"] - apiGroups: ["storage.k8s.io"] resources: ["storageclasses"] verbs: ["get", "list", "watch"] @@ -62,4 +62,4 @@ roleRef: kind: ClusterRole # change the name also here if the ClusterRole gets renamed name: external-snapshotter-runner - apiGroup: rbac.authorization.k8s.io \ No newline at end of file + apiGroup: rbac.authorization.k8s.io