github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

storage error: precondition failure should return invalid object error

pull/6/head
Hongchao Deng 2016-07-24 20:21:17 -07:00
parent 4fdde68f78
commit 60d165a830
4 changed files with 12 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/api/errors/storage/storage.go
View File

@ -65,7 +65,7 @@ func InterpretCreateError(err error, qualifiedResource unversioned.GroupResource
// operation into the appropriate API error. // operation into the appropriate API error.
func InterpretUpdateError(err error, qualifiedResource unversioned.GroupResource, name string) error { func InterpretUpdateError(err error, qualifiedResource unversioned.GroupResource, name string) error {
switch { switch {
case storage.IsTestFailed(err), storage.IsNodeExist(err): case storage.IsTestFailed(err), storage.IsNodeExist(err), storage.IsInvalidObj(err):
return errors.NewConflict(qualifiedResource, name, err) return errors.NewConflict(qualifiedResource, name, err)
case storage.IsUnreachable(err): case storage.IsUnreachable(err):
return errors.NewServerTimeout(qualifiedResource, "update", 2) // TODO: make configurable or handled at a higher level return errors.NewServerTimeout(qualifiedResource, "update", 2) // TODO: make configurable or handled at a higher level
@ -86,7 +86,7 @@ func InterpretDeleteError(err error, qualifiedResource unversioned.GroupResource
return errors.NewNotFound(qualifiedResource, name) return errors.NewNotFound(qualifiedResource, name)
case storage.IsUnreachable(err): case storage.IsUnreachable(err):
return errors.NewServerTimeout(qualifiedResource, "delete", 2) // TODO: make configurable or handled at a higher level return errors.NewServerTimeout(qualifiedResource, "delete", 2) // TODO: make configurable or handled at a higher level
case storage.IsTestFailed(err), storage.IsNodeExist(err): case storage.IsTestFailed(err), storage.IsNodeExist(err), storage.IsInvalidObj(err):
return errors.NewConflict(qualifiedResource, name, err) return errors.NewConflict(qualifiedResource, name, err)
case storage.IsInternalError(err): case storage.IsInternalError(err):
return errors.NewInternalError(err) return errors.NewInternalError(err)

10
pkg/storage/errors.go
View File

@ -107,7 +107,7 @@ func IsUnreachable(err error) bool {
// IsTestFailed returns true if and only if err is a write conflict. // IsTestFailed returns true if and only if err is a write conflict.
func IsTestFailed(err error) bool { func IsTestFailed(err error) bool {
return isErrCode(err, ErrCodeResourceVersionConflicts, ErrCodeInvalidObj) return isErrCode(err, ErrCodeResourceVersionConflicts)
} }
// IsInvalidUID returns true if and only if err is invalid UID error // IsInvalidUID returns true if and only if err is invalid UID error
@ -115,16 +115,12 @@ func IsInvalidObj(err error) bool {
return isErrCode(err, ErrCodeInvalidObj) return isErrCode(err, ErrCodeInvalidObj)
} }
func isErrCode(err error, codes ...int) bool { func isErrCode(err error, code int) bool {
if err == nil { if err == nil {
return false return false
} }
if e, ok := err.(*StorageError); ok { if e, ok := err.(*StorageError); ok {
for _, code := range codes { return e.Code == code
if e.Code == code {
return true
}
}
} }
return false return false
} }

9
pkg/storage/etcd/etcd_helper.go
View File

@ -150,7 +150,7 @@ func (h *etcdHelper) Create(ctx context.Context, key string, obj, out runtime.Ob
return err return err
} }
func checkPreconditions(preconditions *storage.Preconditions, out runtime.Object) error { func checkPreconditions(key string, preconditions *storage.Preconditions, out runtime.Object) error {
if preconditions == nil { if preconditions == nil {
return nil return nil
} }
@ -159,7 +159,8 @@ func checkPreconditions(preconditions *storage.Preconditions, out runtime.Object
return storage.NewInternalErrorf("can't enforce preconditions %v on un-introspectable object %v, got error: %v", *preconditions, out, err) return storage.NewInternalErrorf("can't enforce preconditions %v on un-introspectable object %v, got error: %v", *preconditions, out, err)
} }
if preconditions.UID != nil && *preconditions.UID != objMeta.UID { if preconditions.UID != nil && *preconditions.UID != objMeta.UID {
return etcd.Error{Code: etcd.ErrorCodeTestFailed, Message: fmt.Sprintf("the UID in the precondition (%s) does not match the UID in record (%s). The object might have been deleted and then recreated", *preconditions.UID, objMeta.UID)} errMsg := fmt.Sprintf("Precondition failed: UID in precondition: %v, UID in object meta: %v", preconditions.UID, objMeta.UID)
return storage.NewInvalidObjError(key, errMsg)
} }
return nil return nil
} }
@ -195,7 +196,7 @@ func (h *etcdHelper) Delete(ctx context.Context, key string, out runtime.Object,
if err != nil { if err != nil {
return toStorageErr(err, key, 0) return toStorageErr(err, key, 0)
} }
if err := checkPreconditions(preconditions, obj); err != nil { if err := checkPreconditions(key, preconditions, obj); err != nil {
return toStorageErr(err, key, 0) return toStorageErr(err, key, 0)
} }
index := uint64(0) index := uint64(0)
@ -471,7 +472,7 @@ func (h *etcdHelper) GuaranteedUpdate(ctx context.Context, key string, ptrToType
if err != nil { if err != nil {
return toStorageErr(err, key, 0) return toStorageErr(err, key, 0)
} }
if err := checkPreconditions(preconditions, obj); err != nil { if err := checkPreconditions(key, preconditions, obj); err != nil {
return toStorageErr(err, key, 0) return toStorageErr(err, key, 0)
} }
meta := storage.ResponseMeta{} meta := storage.ResponseMeta{}

4
pkg/storage/etcd/etcd_helper_test.go
View File

@ -460,7 +460,7 @@ func TestGuaranteedUpdateUIDMismatch(t *testing.T) {
err = helper.GuaranteedUpdate(context.TODO(), "/some/key", podPtr, true, storage.NewUIDPreconditions("B"), storage.SimpleUpdate(func(in runtime.Object) (runtime.Object, error) { err = helper.GuaranteedUpdate(context.TODO(), "/some/key", podPtr, true, storage.NewUIDPreconditions("B"), storage.SimpleUpdate(func(in runtime.Object) (runtime.Object, error) {
return obj, nil return obj, nil
})) }))
if !storage.IsTestFailed(err) { if !storage.IsInvalidObj(err) {
t.Fatalf("Expect a Test Failed (write conflict) error, got: %v", err) t.Fatalf("Expect a Test Failed (write conflict) error, got: %v", err)
} }
} }
@ -499,7 +499,7 @@ func TestDeleteUIDMismatch(t *testing.T) {
t.Fatalf("Unexpected error %#v", err) t.Fatalf("Unexpected error %#v", err)
} }
err = helper.Delete(context.TODO(), "/some/key", obj, storage.NewUIDPreconditions("B")) err = helper.Delete(context.TODO(), "/some/key", obj, storage.NewUIDPreconditions("B"))
if !storage.IsTestFailed(err) { if !storage.IsInvalidObj(err) {
t.Fatalf("Expect a Test Failed (write conflict) error, got: %v", err) t.Fatalf("Expect a Test Failed (write conflict) error, got: %v", err)
} }
} }