From 7a05ecd0465f67de0d18535580085dd61d3f14cc Mon Sep 17 00:00:00 2001 From: wackxu Date: Thu, 2 Nov 2017 20:15:34 +0800 Subject: [PATCH] should check and return err when visit failure --- pkg/kubectl/cmd/replace.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/kubectl/cmd/replace.go b/pkg/kubectl/cmd/replace.go index d6f5e26357..40403b2dc4 100644 --- a/pkg/kubectl/cmd/replace.go +++ b/pkg/kubectl/cmd/replace.go @@ -233,7 +233,7 @@ func forceReplace(f cmdutil.Factory, out io.Writer, cmd *cobra.Command, args []s if timeout == 0 { timeout = kubectl.Timeout } - r.Visit(func(info *resource.Info, err error) error { + err = r.Visit(func(info *resource.Info, err error) error { if err != nil { return err } @@ -245,6 +245,9 @@ func forceReplace(f cmdutil.Factory, out io.Writer, cmd *cobra.Command, args []s return true, nil }) }) + if err != nil { + return err + } r = f.NewBuilder(). Unstructured(f.UnstructuredClientForMapping, mapper, typer).