mirror of https://github.com/k3s-io/k3s
Add go profile instrumentation to kubectl
This commit adds two new global options to kubectl: --profile and --profile-output, writing out go profiles to disk to debug interesting and unexpected kubectl behaviour. As an example, here is how to capture a block file, eg. for how long are we blocked on I/O and where? $ kubectl get nodes --profile=mutex -v6 $ go tool pprof -png ./profile.pprof > out.png $ google-chrome out.png Fixes: #68679pull/58/head
parent
94e59f1636
commit
5d634e7db6
|
@ -40,6 +40,7 @@ go_library(
|
||||||
"patch.go",
|
"patch.go",
|
||||||
"plugin.go",
|
"plugin.go",
|
||||||
"portforward.go",
|
"portforward.go",
|
||||||
|
"profiling.go",
|
||||||
"proxy.go",
|
"proxy.go",
|
||||||
"replace.go",
|
"replace.go",
|
||||||
"rollingupdate.go",
|
"rollingupdate.go",
|
||||||
|
|
|
@ -370,6 +370,14 @@ func NewKubectlCommand(in io.Reader, out, err io.Writer) *cobra.Command {
|
||||||
Find more information at:
|
Find more information at:
|
||||||
https://kubernetes.io/docs/reference/kubectl/overview/`),
|
https://kubernetes.io/docs/reference/kubectl/overview/`),
|
||||||
Run: runHelp,
|
Run: runHelp,
|
||||||
|
// Hook before and after Run initialize and write profiles to disk,
|
||||||
|
// respectively.
|
||||||
|
PersistentPreRunE: func(*cobra.Command, []string) error {
|
||||||
|
return initProfiling()
|
||||||
|
},
|
||||||
|
PersistentPostRunE: func(*cobra.Command, []string) error {
|
||||||
|
return flushProfiling()
|
||||||
|
},
|
||||||
BashCompletionFunction: bashCompletionFunc,
|
BashCompletionFunction: bashCompletionFunc,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -380,6 +388,8 @@ func NewKubectlCommand(in io.Reader, out, err io.Writer) *cobra.Command {
|
||||||
// a.k.a. change all "_" to "-". e.g. glog package
|
// a.k.a. change all "_" to "-". e.g. glog package
|
||||||
flags.SetNormalizeFunc(utilflag.WordSepNormalizeFunc)
|
flags.SetNormalizeFunc(utilflag.WordSepNormalizeFunc)
|
||||||
|
|
||||||
|
addProfilingFlags(flags)
|
||||||
|
|
||||||
kubeConfigFlags := genericclioptions.NewConfigFlags()
|
kubeConfigFlags := genericclioptions.NewConfigFlags()
|
||||||
kubeConfigFlags.AddFlags(flags)
|
kubeConfigFlags.AddFlags(flags)
|
||||||
matchVersionKubeConfigFlags := cmdutil.NewMatchVersionFlags(kubeConfigFlags)
|
matchVersionKubeConfigFlags := cmdutil.NewMatchVersionFlags(kubeConfigFlags)
|
||||||
|
|
|
@ -0,0 +1,88 @@
|
||||||
|
/*
|
||||||
|
Copyright 2017 The Kubernetes Authors.
|
||||||
|
|
||||||
|
Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
you may not use this file except in compliance with the License.
|
||||||
|
You may obtain a copy of the License at
|
||||||
|
|
||||||
|
http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
|
||||||
|
Unless required by applicable law or agreed to in writing, software
|
||||||
|
distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
See the License for the specific language governing permissions and
|
||||||
|
limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package cmd
|
||||||
|
|
||||||
|
import (
|
||||||
|
"fmt"
|
||||||
|
"os"
|
||||||
|
"runtime"
|
||||||
|
"runtime/pprof"
|
||||||
|
|
||||||
|
"github.com/spf13/pflag"
|
||||||
|
)
|
||||||
|
|
||||||
|
var (
|
||||||
|
profileName string
|
||||||
|
profileOutput string
|
||||||
|
)
|
||||||
|
|
||||||
|
func addProfilingFlags(flags *pflag.FlagSet) {
|
||||||
|
flags.StringVar(&profileName, "profile", "none", "Name of profile to capture. One of (none|cpu|heap|goroutine|threadcreate|block|mutex)")
|
||||||
|
flags.StringVar(&profileOutput, "profile-output", "profile.pprof", "Name of the file to write the profile to")
|
||||||
|
}
|
||||||
|
|
||||||
|
func initProfiling() error {
|
||||||
|
switch profileName {
|
||||||
|
case "none":
|
||||||
|
return nil
|
||||||
|
case "cpu":
|
||||||
|
f, err := os.Create(profileOutput)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
return pprof.StartCPUProfile(f)
|
||||||
|
// Block and mutex profiles need a call to Set{Block,Mutex}ProfileRate to
|
||||||
|
// output anything. We choose to sample all events.
|
||||||
|
case "block":
|
||||||
|
runtime.SetBlockProfileRate(1)
|
||||||
|
return nil
|
||||||
|
case "mutex":
|
||||||
|
runtime.SetMutexProfileFraction(1)
|
||||||
|
return nil
|
||||||
|
default:
|
||||||
|
// Check the profile name is valid.
|
||||||
|
if profile := pprof.Lookup(profileName); profile == nil {
|
||||||
|
return fmt.Errorf("unknown profile '%s'", profileName)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func flushProfiling() error {
|
||||||
|
switch profileName {
|
||||||
|
case "none":
|
||||||
|
return nil
|
||||||
|
case "cpu":
|
||||||
|
pprof.StopCPUProfile()
|
||||||
|
case "heap":
|
||||||
|
runtime.GC()
|
||||||
|
fallthrough
|
||||||
|
default:
|
||||||
|
profile := pprof.Lookup(profileName)
|
||||||
|
if profile == nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
f, err := os.Create(profileOutput)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
profile.WriteTo(f, 0)
|
||||||
|
}
|
||||||
|
|
||||||
|
return nil
|
||||||
|
}
|
Loading…
Reference in New Issue