AWS: include ELB name in health-check logging

Makes more supportable
pull/6/head
Justin Santa Barbara 2016-09-27 11:20:42 -04:00
parent 8d72f66e47
commit 5bfd15e49e
1 changed files with 5 additions and 3 deletions

View File

@ -317,6 +317,8 @@ func (c *Cloud) ensureLoadBalancer(namespacedName types.NamespacedName, loadBala
// Makes sure that the health check for an ELB matches the configured listeners
func (c *Cloud) ensureLoadBalancerHealthCheck(loadBalancer *elb.LoadBalancerDescription, listeners []*elb.Listener) error {
name := aws.StringValue(loadBalancer.LoadBalancerName)
actual := loadBalancer.HealthCheck
// Default AWS settings
@ -336,7 +338,7 @@ func (c *Cloud) ensureLoadBalancerHealthCheck(loadBalancer *elb.LoadBalancerDesc
}
if expectedTarget == "" {
return fmt.Errorf("unable to determine health check port (no valid listeners)")
return fmt.Errorf("unable to determine health check port for %q (no valid listeners)", name)
}
if expectedTarget == orEmpty(actual.Target) &&
@ -347,7 +349,7 @@ func (c *Cloud) ensureLoadBalancerHealthCheck(loadBalancer *elb.LoadBalancerDesc
return nil
}
glog.V(2).Info("Updating load-balancer health-check")
glog.V(2).Info("Updating load-balancer health-check for %q", name)
healthCheck := &elb.HealthCheck{}
healthCheck.HealthyThreshold = &expectedHealthyThreshold
@ -362,7 +364,7 @@ func (c *Cloud) ensureLoadBalancerHealthCheck(loadBalancer *elb.LoadBalancerDesc
_, err := c.elb.ConfigureHealthCheck(request)
if err != nil {
return fmt.Errorf("error configuring load-balancer health-check: %v", err)
return fmt.Errorf("error configuring load-balancer health-check for %q: %v", name, err)
}
return nil