github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #40621 from timothysc/daemonset_dos 

Automatic merge from submit-queue

Decrease Daemonset burst replicas due to DoS conditions.

**What this PR does / why we need it**:
We are seeing DoS conditions on our Registry if were running a large cluster with too many daemonsets bursting at once.  

**Special notes for your reviewer**:
I decided not to plumb through yet another variable to the command line.  Ideally such parameters could be tweaked via a configuration file.  

**Release note**:

```release-note
NONE
```
pull/6/head
Kubernetes Submit Queue 2017-01-28 06:46:36 -08:00 committed by GitHub
parent 3897fc00db 52bedaf416
commit 597e938e3a
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/controller/daemon/daemoncontroller.go
View File

@ -51,9 +51,8 @@ const (
// Daemon sets will periodically check that their daemon pods are running as expected.
FullDaemonSetResyncPeriod = 30 * time.Second // TODO: Figure out if this time seems reasonable.
// Realistic value of the burstReplica field for the replication manager based off
// performance requirements for kubernetes 1.0.
BurstReplicas = 500
// The value of 250 is chosen b/c values that are too high can cause registry DoS issues
BurstReplicas = 250
// If sending a status upate to API server fails, we retry a finite number of times.
StatusUpdateRetries = 1