From 5518defffc4da501f71fdf4b5449ca8a5a6644fe Mon Sep 17 00:00:00 2001
From: Bob Killen <rkillen@umich.edu>
Date: Sat, 16 Feb 2019 11:17:40 -0500
Subject: [PATCH] Fix shellcheck lint errors in
 test/images/volume/nfs/run_nfs.sh

---
 hack/.shellcheck_failures         |  1 -
 test/images/volume/nfs/run_nfs.sh | 13 +++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures
index 3bcf380580..e2f0195ab0 100644
--- a/hack/.shellcheck_failures
+++ b/hack/.shellcheck_failures
@@ -86,4 +86,3 @@
 ./test/e2e_node/environment/setup_host.sh
 ./test/e2e_node/gubernator.sh
 ./test/images/image-util.sh
-./test/images/volume/nfs/run_nfs.sh
diff --git a/test/images/volume/nfs/run_nfs.sh b/test/images/volume/nfs/run_nfs.sh
index e131de3f32..6b33e2653b 100755
--- a/test/images/volume/nfs/run_nfs.sh
+++ b/test/images/volume/nfs/run_nfs.sh
@@ -22,21 +22,22 @@ function start()
     while getopts "G:" opt; do
         case ${opt} in
             G) gid=${OPTARG};;
+            *):;;
         esac
     done
-    shift $(($OPTIND - 1))
+    shift $((OPTIND - 1))
 
     # prepare /etc/exports
     for i in "$@"; do
         # fsid=0: needed for NFSv4
         echo "$i *(rw,fsid=0,insecure,no_root_squash)" >> /etc/exports
         if [ -v gid ] ; then
-            chmod 070 $i
-            chgrp $gid $i
+            chmod 070 "$i"
+            chgrp "$gid" "$i"
         fi
         # move index.html to here
-        /bin/cp /tmp/index.html $i/
-        chmod 644 $i/index.html
+        /bin/cp /tmp/index.html "$i/"
+        chmod 644 "$i/index.html"
         echo "Serving $i"
     done
 
@@ -67,7 +68,7 @@ function stop()
     /usr/sbin/exportfs -au
     /usr/sbin/exportfs -f
 
-    kill $( pidof rpc.mountd )
+    kill "$( pidof rpc.mountd )"
     umount /proc/fs/nfsd
     echo > /etc/exports
     exit 0