Merge pull request #50353 from zhangxiaoyu-zidif/Delete-redundant-expectError-for-controller-ref-test

Automatic merge from submit-queue

Delete redundant test para. for controller_ref_manager_test

**What this PR does / why we need it**:
The test does not use para. expectError.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

pkg/controller/controller_ref_manager_test.go

@@ -60,13 +60,12 @@ func newPod(podName string, label map[string]string, owner metav1.Object) *v1.Po
 func TestClaimPods(t *testing.T) {
 	controllerKind := schema.GroupVersionKind{}
 	type test struct {
-		name        string
-		manager     *PodControllerRefManager
-		pods        []*v1.Pod
-		filters     []func(*v1.Pod) bool
-		claimed     []*v1.Pod
-		released    []*v1.Pod
-		expectError bool
+		name     string
+		manager  *PodControllerRefManager
+		pods     []*v1.Pod
+		filters  []func(*v1.Pod) bool
+		claimed  []*v1.Pod
+		released []*v1.Pod
 	}
 	var tests = []test{
 		{
@@ -164,8 +163,8 @@ func TestClaimPods(t *testing.T) {
 	}
 	for _, test := range tests {
 		claimed, err := test.manager.ClaimPods(test.pods)
-		if test.expectError && err == nil {
-			t.Errorf("Test case `%s`, expected error but got nil", test.name)
+		if err != nil {
+			t.Errorf("Test case `%s`, unexpected error: %v", test.name, err)
 		} else if !reflect.DeepEqual(test.claimed, claimed) {
 			t.Errorf("Test case `%s`, claimed wrong pods. Expected %v, got %v", test.name, podToStringSlice(test.claimed), podToStringSlice(claimed))
 		}