Merge pull request #691 from erikwilson/early-return-routes

Fix missing early returns on routes
5 years ago · 506d8cdcc3
1 changed files with 2 additions and 0 deletions
--- a/pkg/server/router.go
+++ b/pkg/server/router.go
@ -130,6 +130,7 @@ func servingKubeletCert(server *config.Control) http.Handler {
 		nodeName, nodePassword, err := getNodeInfo(req)
 		if err != nil {
 			sendError(err, resp)
+			return
 		}

 		if err := ensureNodePassword(server.Runtime.NodePasswdFile, nodeName, nodePassword); err != nil {
@ -170,6 +171,7 @@ func clientKubeletCert(server *config.Control) http.Handler {
 		nodeName, nodePassword, err := getNodeInfo(req)
 		if err != nil {
 			sendError(err, resp)
+			return
 		}

 		if err := ensureNodePassword(server.Runtime.NodePasswdFile, nodeName, nodePassword); err != nil {