github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

remove unnecessary TODOs in meta.go

pull/8/head
hangaoshuai 2018-03-15 15:44:23 +08:00
parent 34001d8c6a
commit 4fea1687f6
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
staging/src/k8s.io/apimachinery/pkg/api/meta/meta.go
View File

@ -38,7 +38,6 @@ var errNotCommon = fmt.Errorf("object does not implement the common interface fo
// CommonAccessor returns a Common interface for the provided object or an error if the object does // CommonAccessor returns a Common interface for the provided object or an error if the object does
// not provide List. // not provide List.
// TODO: return bool instead of error
func CommonAccessor(obj interface{}) (metav1.Common, error) { func CommonAccessor(obj interface{}) (metav1.Common, error) {
switch t := obj.(type) { switch t := obj.(type) {
case List: case List:
@ -71,7 +70,6 @@ func CommonAccessor(obj interface{}) (metav1.Common, error) {
// not provide List. // not provide List.
// IMPORTANT: Objects are NOT a superset of lists. Do not use this check to determine whether an // IMPORTANT: Objects are NOT a superset of lists. Do not use this check to determine whether an
// object *is* a List. // object *is* a List.
// TODO: return bool instead of error
func ListAccessor(obj interface{}) (List, error) { func ListAccessor(obj interface{}) (List, error) {
switch t := obj.(type) { switch t := obj.(type) {
case List: case List:
@ -101,7 +99,6 @@ var errNotObject = fmt.Errorf("object does not implement the Object interfaces")
// obj must be a pointer to an API type. An error is returned if the minimum // obj must be a pointer to an API type. An error is returned if the minimum
// required fields are missing. Fields that are not required return the default // required fields are missing. Fields that are not required return the default
// value and are a no-op if set. // value and are a no-op if set.
// TODO: return bool instead of error
func Accessor(obj interface{}) (metav1.Object, error) { func Accessor(obj interface{}) (metav1.Object, error) {
switch t := obj.(type) { switch t := obj.(type) {
case metav1.Object: case metav1.Object: