diff --git a/pkg/volume/util/nestedpendingoperations/nestedpendingoperations.go b/pkg/volume/util/nestedpendingoperations/nestedpendingoperations.go index 1660094524..ed3477bcfa 100644 --- a/pkg/volume/util/nestedpendingoperations/nestedpendingoperations.go +++ b/pkg/volume/util/nestedpendingoperations/nestedpendingoperations.go @@ -196,7 +196,7 @@ func (grm *nestedPendingOperations) getOperation( } logOperationName := getOperationName(volumeName, podName) - return 0, fmt.Errorf("Operation %q not found.", logOperationName) + return 0, fmt.Errorf("Operation %q not found", logOperationName) } func (grm *nestedPendingOperations) deleteOperation( diff --git a/pkg/volume/util/operationexecutor/operation_executor.go b/pkg/volume/util/operationexecutor/operation_executor.go index ee8290f014..03873f30aa 100644 --- a/pkg/volume/util/operationexecutor/operation_executor.go +++ b/pkg/volume/util/operationexecutor/operation_executor.go @@ -624,7 +624,7 @@ func (oe *operationExecutor) generateAttachVolumeFunc( if addVolumeNodeErr != nil { // On failure, return error. Caller will log and retry. return fmt.Errorf( - "AttachVolume.MarkVolumeAsAttached failed for volume %q (spec.Name: %q) from node %q with: %v.", + "AttachVolume.MarkVolumeAsAttached failed for volume %q (spec.Name: %q) from node %q with: %v", volumeToAttach.VolumeName, volumeToAttach.VolumeSpec.Name(), volumeToAttach.NodeName, @@ -731,7 +731,7 @@ func (oe *operationExecutor) verifyVolumeIsSafeToDetach( if node == nil { // On failure, return error. Caller will log and retry. return fmt.Errorf( - "DetachVolume failed fetching node from API server for volume %q (spec.Name: %q) from node %q. Error: node object retrieved from API server is nil.", + "DetachVolume failed fetching node from API server for volume %q (spec.Name: %q) from node %q. Error: node object retrieved from API server is nil", volumeToDetach.VolumeName, volumeToDetach.VolumeSpec.Name(), volumeToDetach.NodeName) @@ -739,7 +739,7 @@ func (oe *operationExecutor) verifyVolumeIsSafeToDetach( for _, inUseVolume := range node.Status.VolumesInUse { if inUseVolume == volumeToDetach.VolumeName { - return fmt.Errorf("DetachVolume failed for volume %q (spec.Name: %q) from node %q. Error: volume is still in use by node, according to Node status.", + return fmt.Errorf("DetachVolume failed for volume %q (spec.Name: %q) from node %q. Error: volume is still in use by node, according to Node status", volumeToDetach.VolumeName, volumeToDetach.VolumeSpec.Name(), volumeToDetach.NodeName) @@ -1139,7 +1139,7 @@ func (oe *operationExecutor) generateVerifyControllerAttachedVolumeFunc( if addVolumeNodeErr != nil { // On failure, return error. Caller will log and retry. return fmt.Errorf( - "VerifyControllerAttachedVolume.MarkVolumeAsAttachedByUniqueVolumeName failed for volume %q (spec.Name: %q) pod %q (UID: %q) with: %v.", + "VerifyControllerAttachedVolume.MarkVolumeAsAttachedByUniqueVolumeName failed for volume %q (spec.Name: %q) pod %q (UID: %q) with: %v", volumeToMount.VolumeName, volumeToMount.VolumeSpec.Name(), volumeToMount.PodName, @@ -1157,7 +1157,7 @@ func (oe *operationExecutor) generateVerifyControllerAttachedVolumeFunc( // periodically by kubelet, so it may take as much as 10 seconds // before this clears. // Issue #28141 to enable on demand status updates. - return fmt.Errorf("Volume %q (spec.Name: %q) pod %q (UID: %q) has not yet been added to the list of VolumesInUse in the node's volume status.", + return fmt.Errorf("Volume %q (spec.Name: %q) pod %q (UID: %q) has not yet been added to the list of VolumesInUse in the node's volume status", volumeToMount.VolumeName, volumeToMount.VolumeSpec.Name(), volumeToMount.PodName, @@ -1169,7 +1169,7 @@ func (oe *operationExecutor) generateVerifyControllerAttachedVolumeFunc( if fetchErr != nil { // On failure, return error. Caller will log and retry. return fmt.Errorf( - "VerifyControllerAttachedVolume failed fetching node from API server. Volume %q (spec.Name: %q) pod %q (UID: %q). Error: %v.", + "VerifyControllerAttachedVolume failed fetching node from API server. Volume %q (spec.Name: %q) pod %q (UID: %q). Error: %v", volumeToMount.VolumeName, volumeToMount.VolumeSpec.Name(), volumeToMount.PodName, @@ -1180,7 +1180,7 @@ func (oe *operationExecutor) generateVerifyControllerAttachedVolumeFunc( if node == nil { // On failure, return error. Caller will log and retry. return fmt.Errorf( - "VerifyControllerAttachedVolume failed. Volume %q (spec.Name: %q) pod %q (UID: %q). Error: node object retrieved from API server is nil.", + "VerifyControllerAttachedVolume failed. Volume %q (spec.Name: %q) pod %q (UID: %q). Error: node object retrieved from API server is nil", volumeToMount.VolumeName, volumeToMount.VolumeSpec.Name(), volumeToMount.PodName, @@ -1201,7 +1201,7 @@ func (oe *operationExecutor) generateVerifyControllerAttachedVolumeFunc( if addVolumeNodeErr != nil { // On failure, return error. Caller will log and retry. return fmt.Errorf( - "VerifyControllerAttachedVolume.MarkVolumeAsAttached failed for volume %q (spec.Name: %q) pod %q (UID: %q) with: %v.", + "VerifyControllerAttachedVolume.MarkVolumeAsAttached failed for volume %q (spec.Name: %q) pod %q (UID: %q) with: %v", volumeToMount.VolumeName, volumeToMount.VolumeSpec.Name(), volumeToMount.PodName, @@ -1213,7 +1213,7 @@ func (oe *operationExecutor) generateVerifyControllerAttachedVolumeFunc( } // Volume not attached, return error. Caller will log and retry. - return fmt.Errorf("Volume %q (spec.Name: %q) pod %q (UID: %q) is not yet attached according to node status.", + return fmt.Errorf("Volume %q (spec.Name: %q) pod %q (UID: %q) is not yet attached according to node status", volumeToMount.VolumeName, volumeToMount.VolumeSpec.Name(), volumeToMount.PodName, diff --git a/test/images/net/main.go b/test/images/net/main.go index 600e273f2d..896bdca9d0 100644 --- a/test/images/net/main.go +++ b/test/images/net/main.go @@ -122,7 +122,7 @@ func executeRunner(name string, rawOptions string) (logOutput, error) { return output, runner.Run(logger, options) } - return logOutput{}, fmt.Errorf("Invalid runner: '%v', see --help\n", runner) + return logOutput{}, fmt.Errorf("Invalid runner: '%v', see --help", runner) } // handleRunRequest handles a request JSON to the network tester.