github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Log error in each loop it appears and fix wrong count of missed cluster.

pull/6/head
xiangpengzhao 2016-07-29 22:01:38 -04:00
parent dfd12276df
commit 4ccd90d741
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
federation/pkg/federation-controller/service/servicecontroller.go
View File

@ -725,23 +725,25 @@ func (s *ServiceController) lockedUpdateDNSRecords(service *cachedService, clust
return nil return nil
} }
var err error ensuredCount := 0
missedCount := 0
unensuredCount := 0 unensuredCount := 0
for key := range s.clusterCache.clientMap { for key := range s.clusterCache.clientMap {
for _, clusterName := range clusterNames { for _, clusterName := range clusterNames {
if key == clusterName { if key == clusterName {
if err = s.ensureDnsRecords(clusterName, service); err != nil { err := s.ensureDnsRecords(clusterName, service)
if err != nil {
unensuredCount += 1 unensuredCount += 1
glog.V(4).Infof("Failed to update DNS records for service %v from cluster %s: %v", service, clusterName, err)
} else {
ensuredCount += 1
} }
} else {
missedCount += 1
} }
} }
} }
missedCount := len(clusterNames) - ensuredCount - unensuredCount
if missedCount > 0 || unensuredCount > 0 { if missedCount > 0 || unensuredCount > 0 {
return fmt.Errorf("Failed to update DNS records for %d clusters for service %v due to missing clients[missed count: %d] or ensuring DNS records error[unensured count: %d] %v", return fmt.Errorf("Failed to update DNS records for %d clusters for service %v due to missing clients [missed count: %d] and/or failing to ensure DNS records [unensured count: %d]",
len(clusterNames), service, missedCount, unensuredCount, err) len(clusterNames), service, missedCount, unensuredCount)
} }
return nil return nil
} }