diff --git a/hack/.golint_failures b/hack/.golint_failures index 708080a8cb..3fd6d1260e 100644 --- a/hack/.golint_failures +++ b/hack/.golint_failures @@ -123,7 +123,6 @@ pkg/features pkg/kubeapiserver pkg/kubeapiserver/options pkg/kubectl -pkg/kubectl/apps pkg/kubectl/cmd/annotate pkg/kubectl/cmd/apply pkg/kubectl/cmd/attach diff --git a/pkg/controller/cronjob/controller_test.go b/pkg/controller/cronjob/controller_test.go index acb96656f2..5c0a0b008e 100644 --- a/pkg/controller/cronjob/controller_test.go +++ b/pkg/controller/cronjob/controller_test.go @@ -153,15 +153,15 @@ func newJob(UID string) batchv1.Job { } var ( - shortDead int64 = 10 - mediumDead int64 = 2 * 60 * 60 - longDead int64 = 1000000 - noDead int64 = -12345 - A batchV1beta1.ConcurrencyPolicy = batchV1beta1.AllowConcurrent - f batchV1beta1.ConcurrencyPolicy = batchV1beta1.ForbidConcurrent - R batchV1beta1.ConcurrencyPolicy = batchV1beta1.ReplaceConcurrent - T = true - F = false + shortDead int64 = 10 + mediumDead int64 = 2 * 60 * 60 + longDead int64 = 1000000 + noDead int64 = -12345 + A = batchV1beta1.AllowConcurrent + f = batchV1beta1.ForbidConcurrent + R = batchV1beta1.ReplaceConcurrent + T = true + F = false ) func TestSyncOne_RunOrNot(t *testing.T) { diff --git a/pkg/kubectl/apps/kind_visitor.go b/pkg/kubectl/apps/kind_visitor.go index 9c3ad07fe7..931c63b183 100644 --- a/pkg/kubectl/apps/kind_visitor.go +++ b/pkg/kubectl/apps/kind_visitor.go @@ -73,17 +73,3 @@ func (elem GroupKindElement) GroupMatch(groups ...string) bool { } return false } - -// NoOpKindVisitor implements KindVisitor with no-op functions. -type NoOpKindVisitor struct{} - -var _ KindVisitor = &NoOpKindVisitor{} - -func (*NoOpKindVisitor) VisitDaemonSet(kind GroupKindElement) {} -func (*NoOpKindVisitor) VisitDeployment(kind GroupKindElement) {} -func (*NoOpKindVisitor) VisitJob(kind GroupKindElement) {} -func (*NoOpKindVisitor) VisitPod(kind GroupKindElement) {} -func (*NoOpKindVisitor) VisitReplicaSet(kind GroupKindElement) {} -func (*NoOpKindVisitor) VisitReplicationController(kind GroupKindElement) {} -func (*NoOpKindVisitor) VisitStatefulSet(kind GroupKindElement) {} -func (*NoOpKindVisitor) VisitCronJob(kind GroupKindElement) {}