From 4c42d542dc634f947cdc24da43baa29fa17faee4 Mon Sep 17 00:00:00 2001 From: xichengliudui <1693291525@qq.com> Date: Tue, 12 Feb 2019 05:38:52 -0500 Subject: [PATCH] Fix golint failures update pull request update pull request --- hack/.golint_failures | 1 - pkg/kubelet/util/cache/object_cache.go | 1 + pkg/kubelet/util/cache/object_cache_test.go | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hack/.golint_failures b/hack/.golint_failures index 682576a48a..99408e2a89 100644 --- a/hack/.golint_failures +++ b/hack/.golint_failures @@ -226,7 +226,6 @@ pkg/kubelet/status/testing pkg/kubelet/sysctl pkg/kubelet/types pkg/kubelet/util -pkg/kubelet/util/cache pkg/kubelet/util/pluginwatcher pkg/kubelet/util/queue pkg/kubelet/util/sliceutils diff --git a/pkg/kubelet/util/cache/object_cache.go b/pkg/kubelet/util/cache/object_cache.go index 56d06908c3..98dbe40534 100644 --- a/pkg/kubelet/util/cache/object_cache.go +++ b/pkg/kubelet/util/cache/object_cache.go @@ -75,6 +75,7 @@ func (c *ObjectCache) Get(key string) (interface{}, error) { return value.(objectEntry).obj, nil } +// Add adds objectEntry by using a unique string as the key. func (c *ObjectCache) Add(key string, obj interface{}) error { err := c.cache.Add(objectEntry{key: key, obj: obj}) if err != nil { diff --git a/pkg/kubelet/util/cache/object_cache_test.go b/pkg/kubelet/util/cache/object_cache_test.go index 5bc09abdd8..792ed2869f 100644 --- a/pkg/kubelet/util/cache/object_cache_test.go +++ b/pkg/kubelet/util/cache/object_cache_test.go @@ -46,7 +46,7 @@ func TestAddAndGet(t *testing.T) { val: "bar", } objectCache := NewFakeObjectCache(func() (interface{}, error) { - return nil, fmt.Errorf("Unexpected Error: updater should never be called in this test!") + return nil, fmt.Errorf("Unexpected Error: updater should never be called in this test") }, 1*time.Hour, clock.NewFakeClock(time.Now())) err := objectCache.Add(testObj.key, testObj.val)