From 476208dec64f9ffab7d360c5175101b614f9bbcc Mon Sep 17 00:00:00 2001 From: Michail Kargakis Date: Tue, 31 May 2016 10:55:49 +0200 Subject: [PATCH] kubectl: make --container-port actually work for expose Even if it was recently deprecated, it should work as expected. --- pkg/kubectl/service.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/kubectl/service.go b/pkg/kubectl/service.go index f67b3a11b4..e8ef5dbac8 100644 --- a/pkg/kubectl/service.go +++ b/pkg/kubectl/service.go @@ -180,11 +180,11 @@ func generate(genericParams map[string]interface{}) (runtime.Object, error) { Ports: ports, }, } - targetPortString, found := params["target-port"] - if !found { - targetPortString, found = params["container-port"] + targetPortString := params["target-port"] + if len(targetPortString) == 0 { + targetPortString = params["container-port"] } - if found && len(targetPortString) > 0 { + if len(targetPortString) > 0 { var targetPort intstr.IntOrString if portNum, err := strconv.Atoi(targetPortString); err != nil { targetPort = intstr.FromString(targetPortString)