rename test file and remove unused code

pull/6/head
hzxuzhonghu 2017-11-10 15:11:44 +08:00
parent 687c8d3297
commit 4685bd8f3b
3 changed files with 1 additions and 18 deletions

View File

@ -8,7 +8,7 @@ load(
go_test( go_test(
name = "go_default_test", name = "go_default_test",
srcs = ["authz_test.go"], srcs = ["builtin_test.go"],
importpath = "k8s.io/apiserver/pkg/authorization/authorizerfactory", importpath = "k8s.io/apiserver/pkg/authorization/authorizerfactory",
library = ":go_default_library", library = ":go_default_library",
deps = [ deps = [

View File

@ -68,19 +68,6 @@ func NewAlwaysDenyAuthorizer() *alwaysDenyAuthorizer {
return new(alwaysDenyAuthorizer) return new(alwaysDenyAuthorizer)
} }
// alwaysFailAuthorizer is an implementation of authorizer.Attributes
// which always says no to an authorization request.
// It is useful in unit tests to force an operation to fail with error.
type alwaysFailAuthorizer struct{}
func (alwaysFailAuthorizer) Authorize(a authorizer.Attributes) (authorized authorizer.Decision, reason string, err error) {
return authorizer.DecisionNoOpinion, "", errors.New("Authorization failure.")
}
func NewAlwaysFailAuthorizer() authorizer.Authorizer {
return new(alwaysFailAuthorizer)
}
type privilegedGroupAuthorizer struct { type privilegedGroupAuthorizer struct {
groups []string groups []string
} }

View File

@ -23,8 +23,6 @@ import (
"k8s.io/apiserver/pkg/authorization/authorizer" "k8s.io/apiserver/pkg/authorization/authorizer"
) )
// NewAlwaysAllowAuthorizer must return a struct which implements authorizer.Authorizer
// and always return nil.
func TestNewAlwaysAllowAuthorizer(t *testing.T) { func TestNewAlwaysAllowAuthorizer(t *testing.T) {
aaa := NewAlwaysAllowAuthorizer() aaa := NewAlwaysAllowAuthorizer()
if decision, _, _ := aaa.Authorize(nil); decision != authorizer.DecisionAllow { if decision, _, _ := aaa.Authorize(nil); decision != authorizer.DecisionAllow {
@ -32,8 +30,6 @@ func TestNewAlwaysAllowAuthorizer(t *testing.T) {
} }
} }
// NewAlwaysDenyAuthorizer must return a struct which implements authorizer.Authorizer
// and always return an error as everything is forbidden.
func TestNewAlwaysDenyAuthorizer(t *testing.T) { func TestNewAlwaysDenyAuthorizer(t *testing.T) {
ada := NewAlwaysDenyAuthorizer() ada := NewAlwaysDenyAuthorizer()
if decision, _, _ := ada.Authorize(nil); decision == authorizer.DecisionAllow { if decision, _, _ := ada.Authorize(nil); decision == authorizer.DecisionAllow {