From 466fee86343afa4998b985f50b4c9155100c3656 Mon Sep 17 00:00:00 2001 From: xiangpengzhao Date: Tue, 1 Nov 2016 04:53:46 -0400 Subject: [PATCH] Optimize port_split_test test case. --- pkg/util/net/port_split_test.go | 44 ++++++++++++++++++++------------- 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a/pkg/util/net/port_split_test.go b/pkg/util/net/port_split_test.go index d15c6e46be..e801bdbea0 100644 --- a/pkg/util/net/port_split_test.go +++ b/pkg/util/net/port_split_test.go @@ -28,16 +28,18 @@ func TestSplitSchemeNamePort(t *testing.T) { normalized bool }{ { - in: "aoeu:asdf", - name: "aoeu", - port: "asdf", - valid: true, + in: "aoeu:asdf", + name: "aoeu", + port: "asdf", + valid: true, + normalized: true, }, { - in: "http:aoeu:asdf", - scheme: "http", - name: "aoeu", - port: "asdf", - valid: true, + in: "http:aoeu:asdf", + scheme: "http", + name: "aoeu", + port: "asdf", + valid: true, + normalized: true, }, { in: "https:aoeu:", scheme: "https", @@ -46,16 +48,22 @@ func TestSplitSchemeNamePort(t *testing.T) { valid: true, normalized: false, }, { - in: "https:aoeu:asdf", - scheme: "https", - name: "aoeu", - port: "asdf", - valid: true, + in: "https:aoeu:asdf", + scheme: "https", + name: "aoeu", + port: "asdf", + valid: true, + normalized: true, }, { in: "aoeu:", name: "aoeu", valid: true, normalized: false, + }, { + in: "aoeu", + name: "aoeu", + valid: true, + normalized: true, }, { in: ":asdf", valid: false, @@ -63,9 +71,11 @@ func TestSplitSchemeNamePort(t *testing.T) { in: "aoeu:asdf:htns", valid: false, }, { - in: "aoeu", - name: "aoeu", - valid: true, + in: "http::asdf", + valid: false, + }, { + in: "http::", + valid: false, }, { in: "", valid: false,