From 7e3d28b30f7e609606c42c9cdc4116bc9024df64 Mon Sep 17 00:00:00 2001 From: Ed Bartosh Date: Tue, 3 Apr 2018 23:22:43 +0300 Subject: [PATCH] Fix wrong usage of kubelet options "--allow-privileged true" is incorrect usage of boolean option. It means setting '--allow-priviledged' to its default value plus non-existing subcommand 'true'. "--allow-privileged false" is even more confusing as it sets allow-priviledged flag to its default value 'true' This is true for any boolean command line option. Fixed this by using correct syntax --allow-priviledged=true Fixed generating of kubelet command line in addKubeletConfigFlags function. --- test/e2e_node/services/kubelet.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/e2e_node/services/kubelet.go b/test/e2e_node/services/kubelet.go index 8672973c86..048e626bdf 100644 --- a/test/e2e_node/services/kubelet.go +++ b/test/e2e_node/services/kubelet.go @@ -264,7 +264,7 @@ func (e *E2EServices) startKubelet() (*server, error) { "--kubeconfig", kubeconfigPath, "--root-dir", KubeletRootDirectory, "--v", LOG_VERBOSITY_LEVEL, "--logtostderr", - "--allow-privileged", "true", + "--allow-privileged=true", ) // Apply test framework feature gates by default. This could also be overridden @@ -354,7 +354,7 @@ func addKubeletConfigFlags(cmdArgs *[]string, kc *kubeletconfig.KubeletConfigura fs := pflag.NewFlagSet("kubelet", pflag.ExitOnError) options.AddKubeletConfigFlags(fs, kc) for _, name := range flags { - *cmdArgs = append(*cmdArgs, "--"+name, fs.Lookup(name).Value.String()) + *cmdArgs = append(*cmdArgs, fmt.Sprintf("--%s=%s", name, fs.Lookup(name).Value.String())) } }