From 3a6c80c372c0f3b904986acab33f0976c8630b9e Mon Sep 17 00:00:00 2001 From: Yago Nobre Date: Mon, 18 Feb 2019 21:33:19 -0300 Subject: [PATCH] Remove todos from init certs phase --- cmd/kubeadm/app/cmd/phases/init/certs.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/cmd/kubeadm/app/cmd/phases/init/certs.go b/cmd/kubeadm/app/cmd/phases/init/certs.go index c3b951f4f1..a04be51b73 100644 --- a/cmd/kubeadm/app/cmd/phases/init/certs.go +++ b/cmd/kubeadm/app/cmd/phases/init/certs.go @@ -225,7 +225,6 @@ func runCAPhase(ca *certsphase.KubeadmCert) func(c workflow.RunData) error { return errors.New("certs phase invoked with an invalid data struct") } - // TODO(EKF): can we avoid loading these certificates every time? if _, err := pkiutil.TryLoadCertFromDisk(data.CertificateDir(), ca.BaseName); err == nil { if _, err := pkiutil.TryLoadKeyFromDisk(data.CertificateDir(), ca.BaseName); err == nil { fmt.Printf("[certs] Using existing %s certificate authority\n", ca.BaseName) @@ -258,7 +257,6 @@ func runCertPhase(cert *certsphase.KubeadmCert, caCert *certsphase.KubeadmCert) return errors.New("certs phase invoked with an invalid data struct") } - // TODO(EKF): can we avoid loading these certificates every time? if certData, _, err := pkiutil.TryLoadCertAndKeyFromDisk(data.CertificateDir(), cert.BaseName); err == nil { caCertData, err := pkiutil.TryLoadCertFromDisk(data.CertificateDir(), caCert.BaseName) if err != nil {