From 37cb9c4dc2f338a32b1b5c37f88b6dc811b6dc87 Mon Sep 17 00:00:00 2001 From: Maru Newby Date: Thu, 18 May 2017 14:21:55 -0700 Subject: [PATCH] fed: Fix bad logic of deletion error handling for federated updater --- federation/pkg/federation-controller/util/federated_updater.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/federation/pkg/federation-controller/util/federated_updater.go b/federation/pkg/federation-controller/util/federated_updater.go index 244fa4c554..dafb8ab3bd 100644 --- a/federation/pkg/federation-controller/util/federated_updater.go +++ b/federation/pkg/federation-controller/util/federated_updater.go @@ -122,7 +122,7 @@ func (fu *federatedUpdaterImpl) Update(ops []FederatedOperation) error { fu.recordEvent(op.Obj, eventType, "Deleting", eventArgs...) err = fu.deleteFunction(clientset, op.Obj) // IsNotFound error is fine since that means the object is deleted already. - if err != nil && !errors.IsNotFound(err) { + if errors.IsNotFound(err) { err = nil } }