Feedback from review

pull/564/head
Thomas Runyon 2019-02-21 06:15:13 -05:00
parent 6770fa7ba5
commit 30c78c7e1c
2 changed files with 444 additions and 438 deletions

View File

@ -1,6 +1,6 @@
# Kubernetes Command-Line Integration Test Suite # Kubernetes Command-Line Integration Test Suite
This document describes how Kubernetes should interact with the Kubernetes command-line integration test suite. This document describes how you can use the Kubernetes command-line integration test-suite.
## Running Tests ## Running Tests
@ -27,7 +27,7 @@ if kube::test::if_supports_resource "${replicasets}" ; then
fi fi
``` ```
Be sure to validate any supported resouces required for the test by using the `kue::test::if_supports_resource` function. Be sure to validate any supported resouces required for the test by using the `kube::test::if_supports_resource` function.
### New File ### New File

View File

@ -386,12 +386,23 @@ runTests() {
kubectl get "${kube_flags[@]}" -f hack/testdata/kubernetes-service.yaml kubectl get "${kube_flags[@]}" -f hack/testdata/kubernetes-service.yaml
fi fi
cleanup(){
kube::test::clear_all
if [[ -n "${foundError}" ]]; then
echo "FAILED TESTS: ""${foundError}"
exit 1
fi
}
if [[ -n "${WHAT-}" ]]; then if [[ -n "${WHAT-}" ]]; then
for pkg in ${WHAT} for pkg in ${WHAT}
do do
record_command run_${pkg}_tests record_command run_${pkg}_tests
done done
else cleanup
return
fi
######################### #########################
# Kubectl version # # Kubectl version #
######################### #########################
@ -854,11 +865,6 @@ runTests() {
#################### ####################
record_command run_wait_tests record_command run_wait_tests
fi
kube::test::clear_all
if [[ -n "${foundError}" ]]; then cleanup
echo "FAILED TESTS: ""${foundError}"
exit 1
fi
} }