From 291f277fe7fdbf3370eb9a833b8afd26e68a0ec7 Mon Sep 17 00:00:00 2001 From: Jan Safranek Date: Mon, 25 Jun 2018 17:39:59 +0200 Subject: [PATCH] azure: Move configuration of resource group in storage class. --- pkg/volume/azure_dd/azure_provision.go | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/pkg/volume/azure_dd/azure_provision.go b/pkg/volume/azure_dd/azure_provision.go index 20cd6f6423..e70f046d3f 100644 --- a/pkg/volume/azure_dd/azure_provision.go +++ b/pkg/volume/azure_dd/azure_provision.go @@ -43,10 +43,6 @@ type azureDiskDeleter struct { var _ volume.Provisioner = &azureDiskProvisioner{} var _ volume.Deleter = &azureDiskDeleter{} -// PVCAnnotationResourceGroup is the annotation used on the PVC -// to specify the resource group of azure managed disk that are not in the same resource group as the cluster. -const PVCAnnotationResourceGroup = "volume.beta.kubernetes.io/resource-group" - func (d *azureDiskDeleter) GetPath() string { return getPath(d.podUID, d.dataDisk.diskName, d.plugin.host) } @@ -98,6 +94,7 @@ func (p *azureDiskProvisioner) Provision(selectedNode *v1.Node, allowedTopologie cachingMode v1.AzureDataDiskCachingMode strKind string err error + resourceGroup string ) // maxLength = 79 - (4 for ".vhd") = 75 name := util.GenerateVolumeName(p.options.ClusterName, p.options.PVName, 75) @@ -121,6 +118,8 @@ func (p *azureDiskProvisioner) Provision(selectedNode *v1.Node, allowedTopologie cachingMode = v1.AzureDataDiskCachingMode(v) case volume.VolumeParameterFSType: fsType = strings.ToLower(v) + case "resourcegroup": + resourceGroup = v default: return nil, fmt.Errorf("AzureDisk - invalid option %s in storage class", k) } @@ -149,10 +148,6 @@ func (p *azureDiskProvisioner) Provision(selectedNode *v1.Node, allowedTopologie // create disk diskURI := "" if kind == v1.AzureManagedDisk { - resourceGroup := "" - if rg, found := p.options.PVC.Annotations[PVCAnnotationResourceGroup]; found { - resourceGroup = rg - } tags := make(map[string]string) if p.options.CloudTags != nil { tags = *(p.options.CloudTags)