github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Avoid unnecessary API calls from GC

pull/6/head
Wojciech Tyczynski 2016-09-18 07:09:11 +02:00
parent 920581d964
commit 27d75054b3
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/controller/garbagecollector/garbagecollector.go
View File

@ -410,7 +410,6 @@ func (p *Propagator) processEvent() {
// the node's owners list. // the node's owners list.
p.removeDependentFromOwners(existingNode, removed) p.removeDependentFromOwners(existingNode, removed)
case event.eventType == deleteEvent: case event.eventType == deleteEvent:
p.gc.absentOwnerCache.Add(accessor.GetUID())
if !found { if !found {
glog.V(6).Infof("%v doesn't exist in the graph, this shouldn't happen", accessor.GetUID()) glog.V(6).Infof("%v doesn't exist in the graph, this shouldn't happen", accessor.GetUID())
return return
@ -418,6 +417,9 @@ func (p *Propagator) processEvent() {
p.removeNode(existingNode) p.removeNode(existingNode)
existingNode.dependentsLock.RLock() existingNode.dependentsLock.RLock()
defer existingNode.dependentsLock.RUnlock() defer existingNode.dependentsLock.RUnlock()
if len(existingNode.dependents) > 0 {
p.gc.absentOwnerCache.Add(accessor.GetUID())
}
for dep := range existingNode.dependents { for dep := range existingNode.dependents {
p.gc.dirtyQueue.Add(&workqueue.TimedWorkQueueItem{StartTime: p.gc.clock.Now(), Object: dep}) p.gc.dirtyQueue.Add(&workqueue.TimedWorkQueueItem{StartTime: p.gc.clock.Now(), Object: dep})
} }
@ -546,7 +548,7 @@ func NewGarbageCollector(metaOnlyClientPool dynamic.ClientPool, clientPool dynam
orphanQueue: workqueue.NewTimedWorkQueue(), orphanQueue: workqueue.NewTimedWorkQueue(),
registeredRateLimiter: NewRegisteredRateLimiter(resources), registeredRateLimiter: NewRegisteredRateLimiter(resources),
registeredRateLimiterForMonitors: NewRegisteredRateLimiter(resources), registeredRateLimiterForMonitors: NewRegisteredRateLimiter(resources),
absentOwnerCache: NewUIDCache(100), absentOwnerCache: NewUIDCache(500),
} }
gc.propagator = &Propagator{ gc.propagator = &Propagator{
eventQueue: workqueue.NewTimedWorkQueue(), eventQueue: workqueue.NewTimedWorkQueue(),