From 6c94d7ae32361e1346e8c47bd03b25210f08cde5 Mon Sep 17 00:00:00 2001 From: hangaoshuai Date: Fri, 27 Jul 2018 20:52:00 +0800 Subject: [PATCH] return err when Unmarshal failed --- pkg/kubectl/rollback.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/kubectl/rollback.go b/pkg/kubectl/rollback.go index 2d984d0d66..027abadc4f 100644 --- a/pkg/kubectl/rollback.go +++ b/pkg/kubectl/rollback.go @@ -418,7 +418,9 @@ func getStatefulSetPatch(set *appsv1.StatefulSet) ([]byte, error) { return nil, err } var raw map[string]interface{} - json.Unmarshal([]byte(str), &raw) + if err := json.Unmarshal([]byte(str), &raw); err != nil { + return nil, err + } objCopy := make(map[string]interface{}) specCopy := make(map[string]interface{}) spec := raw["spec"].(map[string]interface{})