github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

kubectl expose should extract ports from service

pull/6/head
nikhiljindal 2015-07-16 18:02:36 -07:00
parent d397d88499
commit 242910e57c
2 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hack/test-cmd.sh
View File

@ -634,9 +634,13 @@ __EOF__
kubectl expose rc frontend --port=80 --name=frontend-4 --generator=service/v1 "${kube_flags[@]}" kubectl expose rc frontend --port=80 --name=frontend-4 --generator=service/v1 "${kube_flags[@]}"
# Post-condition: service exists and the port is named default. # Post-condition: service exists and the port is named default.
kube::test::get_object_assert 'service frontend-4' "{{$port_name}} {{$port_field}}" 'default 80' kube::test::get_object_assert 'service frontend-4' "{{$port_name}} {{$port_field}}" 'default 80'
# Verify that expose service works without specifying a port.
kubectl expose service frontend --name=frontend-5 "${kube_flags[@]}"
# Post-condition: service exists with the same port as the original service.
kube::test::get_object_assert 'service frontend-5' "{{$port_field}}" '80'
# Cleanup services # Cleanup services
kubectl delete pod valid-pod "${kube_flags[@]}" kubectl delete pod valid-pod "${kube_flags[@]}"
kubectl delete service frontend{,-2,-3,-4} "${kube_flags[@]}" kubectl delete service frontend{,-2,-3,-4,-5} "${kube_flags[@]}"
### Perform a rolling update with --image ### Perform a rolling update with --image
# Command # Command

13
pkg/kubectl/cmd/util/factory.go
View File

@ -177,9 +177,9 @@ func NewFactory(optionalClientConfig clientcmd.ClientConfig) *Factory {
return getPorts(t.Spec.Template.Spec), nil return getPorts(t.Spec.Template.Spec), nil
case *api.Pod: case *api.Pod:
return getPorts(t.Spec), nil return getPorts(t.Spec), nil
case *api.Service:
return getServicePorts(t.Spec), nil
default: default:
// TODO: support extracting ports from service:
// https://github.com/GoogleCloudPlatform/kubernetes/issues/11392
_, kind, err := api.Scheme.ObjectVersionAndKind(object) _, kind, err := api.Scheme.ObjectVersionAndKind(object)
if err != nil { if err != nil {
return nil, err return nil, err
@ -263,6 +263,15 @@ func getPorts(spec api.PodSpec) []string {
return result return result
} }
// Extracts the ports exposed by a service from the given service spec.
func getServicePorts(spec api.ServiceSpec) []string {
result := []string{}
for _, servicePort := range spec.Ports {
result = append(result, strconv.Itoa(servicePort.Port))
}
return result
}
type clientSwaggerSchema struct { type clientSwaggerSchema struct {
c *client.Client c *client.Client
t runtime.ObjectTyper t runtime.ObjectTyper