From f7aca76bac041408b5cdc88f5c52ab76f4880880 Mon Sep 17 00:00:00 2001 From: Kenjiro Nakayama Date: Mon, 31 Dec 2018 13:28:32 +0900 Subject: [PATCH] Fix wrong completion for kubectl attach Although `kubectl attach POD_NAME ` completes container name, kubectl attach needs `-c` option so the command causes error as: ``` $ kubectl attach nginx-7cdbd8cdc9-b5rhr nginx error: the server doesn't have a resource type "nginx-7cdbd8cdc9-b5rhr" ``` This patch changes the completion to the same way as `kubectl exec`. --- pkg/kubectl/cmd/cmd.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/kubectl/cmd/cmd.go b/pkg/kubectl/cmd/cmd.go index 2cfe569e93..9033712e93 100644 --- a/pkg/kubectl/cmd/cmd.go +++ b/pkg/kubectl/cmd/cmd.go @@ -248,11 +248,11 @@ __custom_func() { __kubectl_get_resource return ;; - kubectl_logs | kubectl_attach) + kubectl_logs) __kubectl_require_pod_and_container return ;; - kubectl_exec | kubectl_port-forward | kubectl_top_pod) + kubectl_exec | kubectl_port-forward | kubectl_top_pod | kubectl_attach) __kubectl_get_resource_pod return ;;