From 1ebd51aa7018a69a3196056433e8b079d95e15ba Mon Sep 17 00:00:00 2001 From: Jan Pazdziora Date: Wed, 19 Jul 2017 16:06:41 +0200 Subject: [PATCH] If the init fails for whatever reason, plugin is nil and cannot be used. Addressing === RUN TestCanSupport E0719 13:48:19.829849 2289 driver-call.go:232] init command failed, status: Successx, reason: --- FAIL: TestCanSupport (0.00s) flexvolume_test.go:180: Can't find the plugin by name panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x11fc5b5] --- pkg/volume/flexvolume/flexvolume_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/volume/flexvolume/flexvolume_test.go b/pkg/volume/flexvolume/flexvolume_test.go index 44af4fc505..76ade7b854 100644 --- a/pkg/volume/flexvolume/flexvolume_test.go +++ b/pkg/volume/flexvolume/flexvolume_test.go @@ -177,7 +177,7 @@ func TestCanSupport(t *testing.T) { plugMgr.InitPlugins(ProbeVolumePlugins(tmpDir), volumetest.NewFakeVolumeHost("fake", nil, nil)) plugin, err := plugMgr.FindPluginByName("flexvolume-kubernetes.io/fakeAttacher") if err != nil { - t.Errorf("Can't find the plugin by name") + t.Fatalf("Can't find the plugin by name") } if plugin.GetPluginName() != "flexvolume-kubernetes.io/fakeAttacher" { t.Errorf("Wrong name: %s", plugin.GetPluginName())