diff --git a/Godeps/Godeps.json b/Godeps/Godeps.json index 980fd6aca3..60ec7a96c5 100644 --- a/Godeps/Godeps.json +++ b/Godeps/Godeps.json @@ -514,52 +514,57 @@ }, { "ImportPath": "github.com/coreos/go-systemd/activation", - "Comment": "v5-22-g4484981", + "Comment": "v8-2-g4484981", "Rev": "4484981625c1a6a2ecb40a390fcb6a9bcfee76e3" }, { "ImportPath": "github.com/coreos/go-systemd/daemon", - "Comment": "v5-22-g4484981", + "Comment": "v8-2-g4484981", "Rev": "4484981625c1a6a2ecb40a390fcb6a9bcfee76e3" }, { "ImportPath": "github.com/coreos/go-systemd/dbus", - "Comment": "v5-22-g4484981", + "Comment": "v8-2-g4484981", "Rev": "4484981625c1a6a2ecb40a390fcb6a9bcfee76e3" }, { "ImportPath": "github.com/coreos/go-systemd/journal", - "Comment": "v5-22-g4484981", + "Comment": "v8-2-g4484981", "Rev": "4484981625c1a6a2ecb40a390fcb6a9bcfee76e3" }, { "ImportPath": "github.com/coreos/go-systemd/unit", - "Comment": "v5-22-g4484981", + "Comment": "v8-2-g4484981", "Rev": "4484981625c1a6a2ecb40a390fcb6a9bcfee76e3" }, { "ImportPath": "github.com/coreos/go-systemd/util", - "Comment": "v5-22-g4484981", + "Comment": "v8-2-g4484981", "Rev": "4484981625c1a6a2ecb40a390fcb6a9bcfee76e3" }, { "ImportPath": "github.com/coreos/pkg/capnslog", + "Comment": "v2", "Rev": "7f080b6c11ac2d2347c3cd7521e810207ea1a041" }, { "ImportPath": "github.com/coreos/pkg/dlopen", + "Comment": "v2", "Rev": "7f080b6c11ac2d2347c3cd7521e810207ea1a041" }, { "ImportPath": "github.com/coreos/pkg/health", + "Comment": "v2", "Rev": "7f080b6c11ac2d2347c3cd7521e810207ea1a041" }, { "ImportPath": "github.com/coreos/pkg/httputil", + "Comment": "v2", "Rev": "7f080b6c11ac2d2347c3cd7521e810207ea1a041" }, { "ImportPath": "github.com/coreos/pkg/timeutil", + "Comment": "v2", "Rev": "7f080b6c11ac2d2347c3cd7521e810207ea1a041" }, { @@ -922,203 +927,203 @@ }, { "ImportPath": "github.com/google/cadvisor/api", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/cache/memory", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/collector", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/container", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/container/common", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/container/docker", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/container/libcontainer", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/container/raw", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/container/rkt", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/container/systemd", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/devicemapper", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/events", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/fs", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/healthz", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/http", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/http/mux", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/info/v1", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/info/v1/test", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/info/v2", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/machine", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/manager", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/manager/watcher", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/manager/watcher/raw", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/manager/watcher/rkt", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/metrics", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/pages", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/pages/static", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/storage", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/summary", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/utils", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/utils/cloudinfo", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/utils/cpuload", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/utils/cpuload/netlink", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/utils/docker", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/utils/oomparser", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/utils/sysfs", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/utils/sysinfo", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/utils/tail", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/validate", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/cadvisor/version", - "Comment": "v0.23.3", - "Rev": "6607e7cf50dfc2ef115f5099c6246e3384fbc9a7" + "Comment": "v0.23.4", + "Rev": "7d22cf63253c17bad8ab64b8eef679718d00342e" }, { "ImportPath": "github.com/google/gofuzz", diff --git a/vendor/github.com/armon/go-metrics/.gitignore b/vendor/github.com/armon/go-metrics/.gitignore old mode 100755 new mode 100644 diff --git a/vendor/github.com/armon/go-metrics/metrics.go b/vendor/github.com/armon/go-metrics/metrics.go old mode 100755 new mode 100644 diff --git a/vendor/github.com/armon/go-metrics/sink.go b/vendor/github.com/armon/go-metrics/sink.go old mode 100755 new mode 100644 diff --git a/vendor/github.com/armon/go-metrics/start.go b/vendor/github.com/armon/go-metrics/start.go old mode 100755 new mode 100644 diff --git a/vendor/github.com/armon/go-metrics/statsite.go b/vendor/github.com/armon/go-metrics/statsite.go old mode 100755 new mode 100644 diff --git a/vendor/github.com/coreos/go-oidc/jose/sig.go b/vendor/github.com/coreos/go-oidc/jose/sig.go old mode 100755 new mode 100644 diff --git a/vendor/github.com/coreos/go-oidc/jose/sig_hmac.go b/vendor/github.com/coreos/go-oidc/jose/sig_hmac.go old mode 100755 new mode 100644 diff --git a/vendor/github.com/coreos/go-oidc/jose/sig_rsa.go b/vendor/github.com/coreos/go-oidc/jose/sig_rsa.go old mode 100755 new mode 100644 diff --git a/vendor/github.com/coreos/go-oidc/oidc/key.go b/vendor/github.com/coreos/go-oidc/oidc/key.go old mode 100755 new mode 100644 diff --git a/vendor/github.com/elazarl/goproxy/all.bash b/vendor/github.com/elazarl/goproxy/all.bash old mode 100755 new mode 100644 diff --git a/vendor/github.com/google/cadvisor/container/docker/factory.go b/vendor/github.com/google/cadvisor/container/docker/factory.go index bba692e525..6edfcd935d 100644 --- a/vendor/github.com/google/cadvisor/container/docker/factory.go +++ b/vendor/github.com/google/cadvisor/container/docker/factory.go @@ -197,24 +197,38 @@ func Register(factory info.MachineInfoFactory, fsInfo fs.FsInfo, ignoreMetrics c ) if dockerStorageDriver == devicemapperStorageDriver { - // If the storage drive is devicemapper, create and start a - // ThinPoolWatcher to monitor the size of container CoW layers with - // thin_ls. - dockerThinPoolName, err := dockerutil.DockerThinPoolName(*dockerInfo) - if err != nil { - return fmt.Errorf("couldn't find device mapper thin pool name: %v", err) - } + _, err := devicemapper.ThinLsBinaryPresent() + if err == nil { + // If the storage driver is devicemapper, create and start a + // ThinPoolWatcher to monitor the size of container CoW layers + // with thin_ls. + dockerThinPoolName, err := dockerutil.DockerThinPoolName(*dockerInfo) + if err != nil { + return fmt.Errorf("couldn't find device mapper thin pool name: %v", err) + } - dockerMetadataDevice, err := dockerutil.DockerMetadataDevice(*dockerInfo) - if err != nil { - return fmt.Errorf("couldn't determine devicemapper metadata device") - } + dockerMetadataDevice, err := dockerutil.DockerMetadataDevice(*dockerInfo) + if err != nil { + return fmt.Errorf("couldn't determine devicemapper metadata device: %v", err) + } - thinPoolWatcher = devicemapper.NewThinPoolWatcher(dockerThinPoolName, dockerMetadataDevice) - go thinPoolWatcher.Start() + thinPoolWatcher, err = devicemapper.NewThinPoolWatcher(dockerThinPoolName, dockerMetadataDevice) + if err != nil { + return fmt.Errorf("couldn't create thin pool watcher: %v", err) + } + + go thinPoolWatcher.Start() + } else { + msg := []string{ + "Couldn't locate thin_ls binary; not starting thin pool watcher.", + "Containers backed by thin pools will not show accurate usage.", + "err: %v", + } + glog.Errorf(strings.Join(msg, " "), err) + } } - glog.Infof("registering Docker factory") + glog.Infof("Registering Docker factory") f := &dockerFactory{ cgroupSubsystems: cgroupSubsystems, client: client, diff --git a/vendor/github.com/google/cadvisor/devicemapper/dmsetup_client.go b/vendor/github.com/google/cadvisor/devicemapper/dmsetup_client.go index ec539a6d9b..c0936da9a7 100644 --- a/vendor/github.com/google/cadvisor/devicemapper/dmsetup_client.go +++ b/vendor/github.com/google/cadvisor/devicemapper/dmsetup_client.go @@ -21,19 +21,26 @@ import ( "github.com/golang/glog" ) -// DmsetupClient is a low-level client for interacting with devicemapper via -// the dmsetup utility. +// DmsetupClient is a low-level client for interacting with device mapper via +// the `dmsetup` utility, which is provided by the `device-mapper` package. type DmsetupClient interface { + // Table runs `dmsetup table` on the given device name and returns the + // output or an error. Table(deviceName string) ([]byte, error) + // Message runs `dmsetup message` on the given device, passing the given + // message to the given sector, and returns the output or an error. Message(deviceName string, sector int, message string) ([]byte, error) + // Status runs `dmsetup status` on the given device and returns the output + // or an error. Status(deviceName string) ([]byte, error) } +// NewDmSetupClient returns a new DmsetupClient. func NewDmsetupClient() DmsetupClient { return &defaultDmsetupClient{} } -// defaultDmsetupClient implements the standard behavior for interacting with dmsetup. +// defaultDmsetupClient is a functional DmsetupClient type defaultDmsetupClient struct{} var _ DmsetupClient = &defaultDmsetupClient{} diff --git a/vendor/github.com/google/cadvisor/devicemapper/thin_ls_client.go b/vendor/github.com/google/cadvisor/devicemapper/thin_ls_client.go index f16ed1b258..130172a05e 100644 --- a/vendor/github.com/google/cadvisor/devicemapper/thin_ls_client.go +++ b/vendor/github.com/google/cadvisor/devicemapper/thin_ls_client.go @@ -24,24 +24,38 @@ import ( "github.com/golang/glog" ) -// thinLsClient knows how to run a thin_ls very specific to CoW usage for containers. +// thinLsClient knows how to run a thin_ls very specific to CoW usage for +// containers. type thinLsClient interface { + // ThinLs runs a thin ls on the given device, which is expected to be a + // metadata device. The caller must hold the metadata snapshot for the + // device. ThinLs(deviceName string) (map[string]uint64, error) } -func newThinLsClient() thinLsClient { - return &defaultThinLsClient{} +// newThinLsClient returns a thinLsClient or an error if the thin_ls binary +// couldn't be located. +func newThinLsClient() (thinLsClient, error) { + thinLsPath, err := ThinLsBinaryPresent() + if err != nil { + return nil, fmt.Errorf("error creating thin_ls client: %v", err) + } + + return &defaultThinLsClient{thinLsPath}, nil } -type defaultThinLsClient struct{} +// defaultThinLsClient is a functional thinLsClient +type defaultThinLsClient struct { + thinLsPath string +} var _ thinLsClient = &defaultThinLsClient{} -func (*defaultThinLsClient) ThinLs(deviceName string) (map[string]uint64, error) { +func (c *defaultThinLsClient) ThinLs(deviceName string) (map[string]uint64, error) { args := []string{"--no-headers", "-m", "-o", "DEV,EXCLUSIVE_BYTES", deviceName} glog.V(4).Infof("running command: thin_ls %v", strings.Join(args, " ")) - output, err := exec.Command("thin_ls", args...).Output() + output, err := exec.Command(c.thinLsPath, args...).Output() if err != nil { return nil, fmt.Errorf("Error running command `thin_ls %v`: %v\noutput:\n\n%v", strings.Join(args, " "), err, string(output)) } @@ -49,7 +63,8 @@ func (*defaultThinLsClient) ThinLs(deviceName string) (map[string]uint64, error) return parseThinLsOutput(output), nil } -// parseThinLsOutput parses the output returned by thin_ls to build a map of device id -> usage. +// parseThinLsOutput parses the output returned by thin_ls to build a map of +// device id -> usage. func parseThinLsOutput(output []byte) map[string]uint64 { cache := map[string]uint64{} diff --git a/vendor/github.com/google/cadvisor/devicemapper/thin_pool_watcher.go b/vendor/github.com/google/cadvisor/devicemapper/thin_pool_watcher.go index f9adecfebb..4062f1fed2 100644 --- a/vendor/github.com/google/cadvisor/devicemapper/thin_pool_watcher.go +++ b/vendor/github.com/google/cadvisor/devicemapper/thin_pool_watcher.go @@ -22,7 +22,8 @@ import ( "github.com/golang/glog" ) -// ThinPoolWatcher maintains a cache of device name -> usage stats for a devicemapper thin-pool using thin_ls. +// ThinPoolWatcher maintains a cache of device name -> usage stats for a +// devicemapper thin-pool using thin_ls. type ThinPoolWatcher struct { poolName string metadataDevice string @@ -34,8 +35,14 @@ type ThinPoolWatcher struct { thinLsClient thinLsClient } -// NewThinPoolWatcher returns a new ThinPoolWatcher for the given devicemapper thin pool name and metadata device. -func NewThinPoolWatcher(poolName, metadataDevice string) *ThinPoolWatcher { +// NewThinPoolWatcher returns a new ThinPoolWatcher for the given devicemapper +// thin pool name and metadata device or an error. +func NewThinPoolWatcher(poolName, metadataDevice string) (*ThinPoolWatcher, error) { + thinLsClient, err := newThinLsClient() + if err != nil { + return nil, fmt.Errorf("encountered error creating thin_ls client: %v", err) + } + return &ThinPoolWatcher{poolName: poolName, metadataDevice: metadataDevice, lock: &sync.RWMutex{}, @@ -43,11 +50,11 @@ func NewThinPoolWatcher(poolName, metadataDevice string) *ThinPoolWatcher { period: 15 * time.Second, stopChan: make(chan struct{}), dmsetup: NewDmsetupClient(), - thinLsClient: newThinLsClient(), - } + thinLsClient: thinLsClient, + }, nil } -// Start starts the thin pool watcher. +// Start starts the ThinPoolWatcher. func (w *ThinPoolWatcher) Start() { err := w.Refresh() if err != nil { @@ -72,6 +79,7 @@ func (w *ThinPoolWatcher) Start() { } } +// Stop stops the ThinPoolWatcher. func (w *ThinPoolWatcher) Stop() { close(w.stopChan) } @@ -80,6 +88,7 @@ func (w *ThinPoolWatcher) Stop() { func (w *ThinPoolWatcher) GetUsage(deviceId string) (uint64, error) { w.lock.RLock() defer w.lock.RUnlock() + v, ok := w.cache[deviceId] if !ok { return 0, fmt.Errorf("no cached value for usage of device %v", deviceId) @@ -115,7 +124,8 @@ func (w *ThinPoolWatcher) Refresh() error { } glog.Infof("reserving metadata snapshot for thin-pool %v", w.poolName) - // NOTE: "0" in the call below is for the 'sector' argument to 'dmsetup message'. It's not needed for thin pools. + // NOTE: "0" in the call below is for the 'sector' argument to 'dmsetup + // message'. It's not needed for thin pools. if output, err := w.dmsetup.Message(w.poolName, 0, reserveMetadataMessage); err != nil { err = fmt.Errorf("error reserving metadata for thin-pool %v: %v output: %v", w.poolName, err, string(output)) return err @@ -144,7 +154,8 @@ const ( thinPoolDmsetupStatusHeldMetadataRoot = 6 ) -// checkReservation checks to see whether the thin device is currently holding userspace metadata. +// checkReservation checks to see whether the thin device is currently holding +// userspace metadata. func (w *ThinPoolWatcher) checkReservation(poolName string) (bool, error) { glog.V(5).Infof("checking whether the thin-pool is holding a metadata snapshot") output, err := w.dmsetup.Status(poolName) @@ -153,7 +164,8 @@ func (w *ThinPoolWatcher) checkReservation(poolName string) (bool, error) { } tokens := strings.Split(string(output), " ") - // Split returns the input as the last item in the result, adjust the number of tokens by one + // Split returns the input as the last item in the result, adjust the + // number of tokens by one if len(tokens) != thinPoolDmsetupStatusTokens+1 { return false, fmt.Errorf("unexpected output of dmsetup status command; expected 11 fields, got %v; output: %v", len(tokens), string(output)) } diff --git a/vendor/github.com/google/cadvisor/devicemapper/util.go b/vendor/github.com/google/cadvisor/devicemapper/util.go new file mode 100644 index 0000000000..0621972ae6 --- /dev/null +++ b/vendor/github.com/google/cadvisor/devicemapper/util.go @@ -0,0 +1,60 @@ +// Copyright 2016 Google Inc. All Rights Reserved. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +package devicemapper + +import ( + "fmt" + "os" + "path/filepath" +) + +// ThinLsBinaryPresent returns the location of the thin_ls binary in the mount +// namespace cadvisor is running in or an error. The locations checked are: +// +// - /bin/ +// - /usr/sbin/ +// - /usr/bin/ +// +// ThinLsBinaryPresent checks these paths relative to: +// +// 1. For non-containerized operation - `/` +// 2. For containerized operation - `/rootfs` +// +// The thin_ls binary is provided by the device-mapper-persistent-data +// package. +func ThinLsBinaryPresent() (string, error) { + var ( + thinLsPath string + err error + ) + + for _, path := range []string{"/bin", "/usr/sbin/", "/usr/bin"} { + // try paths for non-containerized operation + // note: thin_ls is most likely a symlink to pdata_tools + thinLsPath = filepath.Join(path, "thin_ls") + _, err = os.Stat(thinLsPath) + if err == nil { + return thinLsPath, nil + } + + // try paths for containerized operation + thinLsPath = filepath.Join("/rootfs", thinLsPath) + _, err = os.Stat(thinLsPath) + if err == nil { + return thinLsPath, nil + } + } + + return "", fmt.Errorf("unable to find thin_ls binary") +} diff --git a/vendor/github.com/google/cadvisor/info/v2/conversion.go b/vendor/github.com/google/cadvisor/info/v2/conversion.go index 739ccefc6a..b6664ecc23 100644 --- a/vendor/github.com/google/cadvisor/info/v2/conversion.go +++ b/vendor/github.com/google/cadvisor/info/v2/conversion.go @@ -206,7 +206,8 @@ func InstCpuStats(last, cur *v1.ContainerStats) (*CpuInstStats, error) { return 0, fmt.Errorf("cumulative stats decrease") } valueDelta := curValue - lastValue - return (valueDelta * 1e9) / timeDeltaNs, nil + // Use float64 to keep precision + return uint64(float64(valueDelta) / float64(timeDeltaNs) * 1e9), nil } total, err := convertToRate(last.Cpu.Usage.Total, cur.Cpu.Usage.Total) if err != nil { @@ -268,57 +269,3 @@ func ContainerSpecFromV1(specV1 *v1.ContainerSpec, aliases []string, namespace s specV2.Namespace = namespace return specV2 } - -func instCpuStats(last, cur *v1.ContainerStats) (*CpuInstStats, error) { - if last == nil { - return nil, nil - } - if !cur.Timestamp.After(last.Timestamp) { - return nil, fmt.Errorf("container stats move backwards in time") - } - if len(last.Cpu.Usage.PerCpu) != len(cur.Cpu.Usage.PerCpu) { - return nil, fmt.Errorf("different number of cpus") - } - timeDelta := cur.Timestamp.Sub(last.Timestamp) - if timeDelta <= 100*time.Millisecond { - return nil, fmt.Errorf("time delta unexpectedly small") - } - // Nanoseconds to gain precision and avoid having zero seconds if the - // difference between the timestamps is just under a second - timeDeltaNs := uint64(timeDelta.Nanoseconds()) - convertToRate := func(lastValue, curValue uint64) (uint64, error) { - if curValue < lastValue { - return 0, fmt.Errorf("cumulative stats decrease") - } - valueDelta := curValue - lastValue - return (valueDelta * 1e9) / timeDeltaNs, nil - } - total, err := convertToRate(last.Cpu.Usage.Total, cur.Cpu.Usage.Total) - if err != nil { - return nil, err - } - percpu := make([]uint64, len(last.Cpu.Usage.PerCpu)) - for i := range percpu { - var err error - percpu[i], err = convertToRate(last.Cpu.Usage.PerCpu[i], cur.Cpu.Usage.PerCpu[i]) - if err != nil { - return nil, err - } - } - user, err := convertToRate(last.Cpu.Usage.User, cur.Cpu.Usage.User) - if err != nil { - return nil, err - } - system, err := convertToRate(last.Cpu.Usage.System, cur.Cpu.Usage.System) - if err != nil { - return nil, err - } - return &CpuInstStats{ - Usage: CpuInstUsage{ - Total: total, - PerCpu: percpu, - User: user, - System: system, - }, - }, nil -} diff --git a/vendor/github.com/google/cadvisor/version/VERSION b/vendor/github.com/google/cadvisor/version/VERSION index 9e40e75c5d..40a6dfede5 100644 --- a/vendor/github.com/google/cadvisor/version/VERSION +++ b/vendor/github.com/google/cadvisor/version/VERSION @@ -1 +1 @@ -0.23.3 +0.23.4 diff --git a/vendor/github.com/hashicorp/go-msgpack/codec/msgpack_test.py b/vendor/github.com/hashicorp/go-msgpack/codec/msgpack_test.py old mode 100755 new mode 100644 diff --git a/vendor/github.com/kr/pty/mktypes.bash b/vendor/github.com/kr/pty/mktypes.bash old mode 100755 new mode 100644 diff --git a/vendor/github.com/pborman/uuid/dce.go b/vendor/github.com/pborman/uuid/dce.go old mode 100755 new mode 100644 diff --git a/vendor/github.com/pborman/uuid/doc.go b/vendor/github.com/pborman/uuid/doc.go old mode 100755 new mode 100644 diff --git a/vendor/github.com/pborman/uuid/node.go b/vendor/github.com/pborman/uuid/node.go old mode 100755 new mode 100644 diff --git a/vendor/github.com/pborman/uuid/time.go b/vendor/github.com/pborman/uuid/time.go old mode 100755 new mode 100644 diff --git a/vendor/github.com/pborman/uuid/uuid.go b/vendor/github.com/pborman/uuid/uuid.go old mode 100755 new mode 100644 diff --git a/vendor/github.com/ugorji/go/codec/prebuild.sh b/vendor/github.com/ugorji/go/codec/prebuild.sh old mode 100755 new mode 100644 diff --git a/vendor/github.com/ugorji/go/codec/test.py b/vendor/github.com/ugorji/go/codec/test.py old mode 100755 new mode 100644 diff --git a/vendor/github.com/ugorji/go/codec/tests.sh b/vendor/github.com/ugorji/go/codec/tests.sh old mode 100755 new mode 100644 diff --git a/vendor/golang.org/x/sys/unix/mkall.sh b/vendor/golang.org/x/sys/unix/mkall.sh old mode 100755 new mode 100644 diff --git a/vendor/golang.org/x/sys/unix/mkerrors.sh b/vendor/golang.org/x/sys/unix/mkerrors.sh old mode 100755 new mode 100644 diff --git a/vendor/golang.org/x/sys/unix/mksyscall.pl b/vendor/golang.org/x/sys/unix/mksyscall.pl old mode 100755 new mode 100644 diff --git a/vendor/golang.org/x/sys/unix/mksyscall_solaris.pl b/vendor/golang.org/x/sys/unix/mksyscall_solaris.pl old mode 100755 new mode 100644 diff --git a/vendor/golang.org/x/sys/unix/mksysctl_openbsd.pl b/vendor/golang.org/x/sys/unix/mksysctl_openbsd.pl old mode 100755 new mode 100644 diff --git a/vendor/golang.org/x/sys/unix/mksysnum_darwin.pl b/vendor/golang.org/x/sys/unix/mksysnum_darwin.pl old mode 100755 new mode 100644 diff --git a/vendor/golang.org/x/sys/unix/mksysnum_dragonfly.pl b/vendor/golang.org/x/sys/unix/mksysnum_dragonfly.pl old mode 100755 new mode 100644 diff --git a/vendor/golang.org/x/sys/unix/mksysnum_freebsd.pl b/vendor/golang.org/x/sys/unix/mksysnum_freebsd.pl old mode 100755 new mode 100644 diff --git a/vendor/golang.org/x/sys/unix/mksysnum_linux.pl b/vendor/golang.org/x/sys/unix/mksysnum_linux.pl old mode 100755 new mode 100644 diff --git a/vendor/golang.org/x/sys/unix/mksysnum_netbsd.pl b/vendor/golang.org/x/sys/unix/mksysnum_netbsd.pl old mode 100755 new mode 100644 diff --git a/vendor/golang.org/x/sys/unix/mksysnum_openbsd.pl b/vendor/golang.org/x/sys/unix/mksysnum_openbsd.pl old mode 100755 new mode 100644 diff --git a/vendor/google.golang.org/grpc/codegen.sh b/vendor/google.golang.org/grpc/codegen.sh old mode 100755 new mode 100644 diff --git a/vendor/google.golang.org/grpc/coverage.sh b/vendor/google.golang.org/grpc/coverage.sh old mode 100755 new mode 100644