From 17fd66946b1b36056af1262c7c23088343227d63 Mon Sep 17 00:00:00 2001 From: Rajat Varyani Date: Fri, 8 Feb 2019 21:30:34 +0530 Subject: [PATCH] Fix linting in cmd/kubemark package --- cmd/kubemark/hollow-node.go | 10 +++++----- hack/.golint_failures | 1 - 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/cmd/kubemark/hollow-node.go b/cmd/kubemark/hollow-node.go index bd7888f40c..578c629070 100644 --- a/cmd/kubemark/hollow-node.go +++ b/cmd/kubemark/hollow-node.go @@ -49,7 +49,7 @@ import ( fakeexec "k8s.io/utils/exec/testing" ) -type HollowNodeConfig struct { +type hollowNodeConfig struct { KubeconfigPath string KubeletPort int KubeletReadOnlyPort int @@ -71,7 +71,7 @@ const ( // and make the config driven. var knownMorphs = sets.NewString("kubelet", "proxy") -func (c *HollowNodeConfig) addFlags(fs *pflag.FlagSet) { +func (c *hollowNodeConfig) addFlags(fs *pflag.FlagSet) { fs.StringVar(&c.KubeconfigPath, "kubeconfig", "/kubeconfig/kubeconfig", "Path to kubeconfig file.") fs.IntVar(&c.KubeletPort, "kubelet-port", 10250, "Port on which HollowKubelet should be listening.") fs.IntVar(&c.KubeletReadOnlyPort, "kubelet-read-only-port", 10255, "Read-only port on which Kubelet is listening.") @@ -84,7 +84,7 @@ func (c *HollowNodeConfig) addFlags(fs *pflag.FlagSet) { fs.DurationVar(&c.ProxierMinSyncPeriod, "proxier-min-sync-period", 0, "Minimum period that proxy rules are refreshed in hollow-proxy.") } -func (c *HollowNodeConfig) createClientConfigFromFile() (*restclient.Config, error) { +func (c *hollowNodeConfig) createClientConfigFromFile() (*restclient.Config, error) { clientConfig, err := clientcmd.LoadFromFile(c.KubeconfigPath) if err != nil { return nil, fmt.Errorf("error while loading kubeconfig from file %v: %v", c.KubeconfigPath, err) @@ -121,7 +121,7 @@ func main() { // newControllerManagerCommand creates a *cobra.Command object with default parameters func newHollowNodeCommand() *cobra.Command { - s := &HollowNodeConfig{} + s := &hollowNodeConfig{} cmd := &cobra.Command{ Use: "kubemark", @@ -136,7 +136,7 @@ func newHollowNodeCommand() *cobra.Command { return cmd } -func run(config *HollowNodeConfig) { +func run(config *hollowNodeConfig) { if !knownMorphs.Has(config.Morph) { klog.Fatalf("Unknown morph: %v. Allowed values: %v", config.Morph, knownMorphs.List()) } diff --git a/hack/.golint_failures b/hack/.golint_failures index 171a726ab8..f9b01c886b 100644 --- a/hack/.golint_failures +++ b/hack/.golint_failures @@ -9,7 +9,6 @@ cmd/kubeadm/app/util/config cmd/kubeadm/app/util/system cmd/kubelet/app cmd/kubelet/app/options -cmd/kubemark pkg/apis/abac/latest pkg/apis/admission pkg/apis/admission/v1beta1