From 11fabd71763835796a45da2fffabf252f918c07a Mon Sep 17 00:00:00 2001 From: Marcin Wielgus Date: Mon, 22 Aug 2016 11:09:05 +0200 Subject: [PATCH] Scheduling algorithm provider flag in kube-up.sh --- cluster/common.sh | 5 +++++ cluster/gce/config-default.sh | 3 +++ cluster/gce/config-test.sh | 3 +++ cluster/gce/configure-vm.sh | 5 +++++ cluster/gce/gci/configure-helper.sh | 3 +++ cluster/gce/trusty/configure-helper.sh | 4 ++++ .../saltbase/salt/kube-scheduler/kube-scheduler.manifest | 9 +++++++-- hack/verify-flags/exceptions.txt | 6 +----- 8 files changed, 31 insertions(+), 7 deletions(-) diff --git a/cluster/common.sh b/cluster/common.sh index 222f18d07b..e87506e0f5 100755 --- a/cluster/common.sh +++ b/cluster/common.sh @@ -759,6 +759,11 @@ EOF if [ -n "${DNS_ZONE_NAME:-}" ]; then cat >>$file <>$file <>/srv/salt-overlay/pillar/cluster-params.sls federations_domain_map: '' +EOF + fi + if [ -n "${SCHEDULING_ALGORITHM_PROVIDER:-}" ]; then + cat <>/srv/salt-overlay/pillar/cluster-params.sls +scheduling_algorithm_provider: '$(echo "${SCHEDULING_ALGORITHM_PROVIDER}" | sed -e "s/'/''/g")' EOF fi } diff --git a/cluster/gce/gci/configure-helper.sh b/cluster/gce/gci/configure-helper.sh index 8b14cbb5a6..1a54662073 100644 --- a/cluster/gce/gci/configure-helper.sh +++ b/cluster/gce/gci/configure-helper.sh @@ -809,6 +809,9 @@ function start-kube-scheduler { if [[ -n "${FEATURE_GATES:-}" ]]; then params+=" --feature-gates=${FEATURE_GATES}" fi + if [[ -n "${SCHEDULING_ALGORITHM_PROVIDER:-}" ]]; then + params+=" --algorithm-provider=${SCHEDULING_ALGORITHM_PROVIDER}" + fi local -r kube_scheduler_docker_tag=$(cat "${KUBE_HOME}/kube-docker-files/kube-scheduler.docker_tag") # Remove salt comments and replace variables with values. diff --git a/cluster/gce/trusty/configure-helper.sh b/cluster/gce/trusty/configure-helper.sh index 96a69a208f..2968fc9b8a 100644 --- a/cluster/gce/trusty/configure-helper.sh +++ b/cluster/gce/trusty/configure-helper.sh @@ -675,6 +675,10 @@ start_kube_scheduler() { log_level="${SCHEDULER_TEST_LOG_LEVEL}" fi params="${log_level} ${SCHEDULER_TEST_ARGS:-}" + if [ -n "${SCHEDULING_ALGORITHM_PROVIDER:-}" ]; then + params="${params} --algorithm-provider=${SCHEDULING_ALGORITHM_PROVIDER}" + fi + readonly kube_scheduler_docker_tag=$(cat "${kube_home}/kube-docker-files/kube-scheduler.docker_tag") # Remove salt comments and replace variables with values diff --git a/cluster/saltbase/salt/kube-scheduler/kube-scheduler.manifest b/cluster/saltbase/salt/kube-scheduler/kube-scheduler.manifest index b4941a4df0..bb64d3e72c 100644 --- a/cluster/saltbase/salt/kube-scheduler/kube-scheduler.manifest +++ b/cluster/saltbase/salt/kube-scheduler/kube-scheduler.manifest @@ -7,10 +7,15 @@ {% set feature_gates = "" -%} {% if grains.feature_gates is defined -%} - {% set feature_gates = "--feature-gates=" + grains.feature_gates -%} + {% set feature_gates = "--feature-gates=" + grains.feature_gates -%} {% endif -%} -{% set params = params + log_level + " " + feature_gates -%} +{% set scheduling_algorithm_provider = "" -%} +{% if grains.scheduling_algorithm_provider is defined -%} + {% set scheduling_algorithm_provider = "--algorithm-provider=" + grains.scheduling_algorithm_provider -%} +{% endif -%} + +{% set params = params + log_level + " " + feature_gates + " " + scheduling_algorithm_provider -%} # test_args has to be kept at the end, so they'll overwrite any prior configuration {% if pillar['scheduler_test_args'] is defined -%} diff --git a/hack/verify-flags/exceptions.txt b/hack/verify-flags/exceptions.txt index b60c34841e..1cc45f4a26 100644 --- a/hack/verify-flags/exceptions.txt +++ b/hack/verify-flags/exceptions.txt @@ -50,7 +50,7 @@ cluster/saltbase/salt/kube-proxy/kube-proxy.manifest: {% set api_servers_with_p cluster/saltbase/salt/kube-proxy/kube-proxy.manifest: {% set api_servers_with_port = api_servers -%} cluster/saltbase/salt/kube-proxy/kube-proxy.manifest: {% set cluster_cidr=" --cluster-cidr=" + pillar['cluster_cidr'] %} cluster/saltbase/salt/kube-proxy/kube-proxy.manifest:{% set params = log_level + " " + feature_gates + " " + test_args -%} -cluster/saltbase/salt/kube-scheduler/kube-scheduler.manifest:{% set params = params + log_level + " " + feature_gates -%} +cluster/saltbase/salt/kube-scheduler/kube-scheduler.manifest:{% set params = params + log_level + " " + feature_gates + " " + scheduling_algorithm_provider -%} cluster/saltbase/salt/kubelet/default: {% set api_servers_with_port = api_servers + ":6443" -%} cluster/saltbase/salt/kubelet/default: {% set api_servers_with_port = api_servers -%} cluster/saltbase/salt/kubelet/default: {% set enable_custom_metrics="--enable-custom-metrics=" + pillar['enable_custom_metrics'] %} @@ -84,10 +84,6 @@ federation/config.default.json: "cluster_name": "cluster3-kubernetes", federation/config.default.json: "num_nodes": 3, federation/config.default.json: "num_nodes": 3, federation/config.default.json: "num_nodes": 3, -hack/fed-up-cluster.sh: advertise_address="--advertise_address=${API_HOST}" -hack/fed-up-cluster.sh: runtime_config="--runtime-config=${RUNTIME_CONFIG}" -hack/fed-up-cluster.sh: advertise_address="" -hack/fed-up-cluster.sh: runtime_config="" hack/local-up-cluster.sh: advertise_address="--advertise_address=${API_HOST}" hack/local-up-cluster.sh: runtime_config="--runtime-config=${RUNTIME_CONFIG}" hack/local-up-cluster.sh: advertise_address=""