From d2532b50ce4f8b14eceac92b50228c98bf0f9a14 Mon Sep 17 00:00:00 2001
From: "Tim St. Clair" <stclair@google.com>
Date: Tue, 24 Nov 2015 18:27:43 -0800
Subject: [PATCH] Correct backwards pod mappings

The mapping of static pod <--> mirror pod UIDs was backwards in a couple
places. Fortunately, they canceled each other out. Fixed, and added a
test case.
---
 pkg/kubelet/pod/manager.go         |  7 ++++--
 pkg/kubelet/status/manager.go      |  8 +++---
 pkg/kubelet/status/manager_test.go | 39 ++++++++++++++++++++++++++++++
 3 files changed, 48 insertions(+), 6 deletions(-)

diff --git a/pkg/kubelet/pod/manager.go b/pkg/kubelet/pod/manager.go
index 63b68bc5ad..57b418102a 100644
--- a/pkg/kubelet/pod/manager.go
+++ b/pkg/kubelet/pod/manager.go
@@ -130,6 +130,9 @@ func (pm *basicManager) updatePodsInternal(pods ...*api.Pod) {
 		} else {
 			pm.podByUID[pod.UID] = pod
 			pm.podByFullName[podFullName] = pod
+			if mirror, ok := pm.mirrorPodByFullName[podFullName]; ok {
+				pm.translationByUID[mirror.UID] = pod.UID
+			}
 		}
 	}
 }
@@ -218,8 +221,8 @@ func (pm *basicManager) GetUIDTranslations() (podToMirror, mirrorToPod map[types
 	podToMirror = make(map[types.UID]types.UID, len(pm.translationByUID))
 	mirrorToPod = make(map[types.UID]types.UID, len(pm.translationByUID))
 	for k, v := range pm.translationByUID {
-		podToMirror[k] = v
-		mirrorToPod[v] = k
+		mirrorToPod[k] = v
+		podToMirror[v] = k
 	}
 	return podToMirror, mirrorToPod
 }
diff --git a/pkg/kubelet/status/manager.go b/pkg/kubelet/status/manager.go
index 30d6f37a60..920890c8f9 100644
--- a/pkg/kubelet/status/manager.go
+++ b/pkg/kubelet/status/manager.go
@@ -60,7 +60,7 @@ type manager struct {
 	podStatuses      map[types.UID]versionedPodStatus
 	podStatusesLock  sync.RWMutex
 	podStatusChannel chan podStatusSyncRequest
-	// Map from pod UID to latest status version successfully sent to the API server.
+	// Map from (mirror) pod UID to latest status version successfully sent to the API server.
 	// apiStatusVersions must only be accessed from the sync thread.
 	apiStatusVersions map[types.UID]uint64
 }
@@ -296,7 +296,7 @@ func (m *manager) syncBatch() {
 		// Clean up orphaned versions.
 		for uid := range m.apiStatusVersions {
 			_, hasPod := m.podStatuses[uid]
-			_, hasMirror := podToMirror[uid]
+			_, hasMirror := mirrorToPod[uid]
 			if !hasPod && !hasMirror {
 				delete(m.apiStatusVersions, uid)
 			}
@@ -304,8 +304,8 @@ func (m *manager) syncBatch() {
 
 		for uid, status := range m.podStatuses {
 			syncedUID := uid
-			if translated, ok := mirrorToPod[uid]; ok {
-				syncedUID = translated
+			if mirrorUID, ok := podToMirror[uid]; ok {
+				syncedUID = mirrorUID
 			}
 			if m.needsUpdate(syncedUID, status) {
 				updatedStatuses = append(updatedStatuses, podStatusSyncRequest{uid, status})
diff --git a/pkg/kubelet/status/manager_test.go b/pkg/kubelet/status/manager_test.go
index add09a14c0..c6c0b368b2 100644
--- a/pkg/kubelet/status/manager_test.go
+++ b/pkg/kubelet/status/manager_test.go
@@ -538,3 +538,42 @@ func TestSetContainerReadiness(t *testing.T) {
 	m.SetContainerReadiness(testPod, kubecontainer.ContainerID{"test", "foo"}, true)
 	verifyUpdates(t, m, 0)
 }
+
+func TestSyncBatchCleanupVersions(t *testing.T) {
+	m := newTestManager(&testclient.Fake{})
+	mirrorPod := *testPod
+	mirrorPod.UID = "mirror-uid"
+	mirrorPod.Name = "mirror_pod"
+	mirrorPod.Annotations = map[string]string{
+		kubetypes.ConfigSourceAnnotationKey: "api",
+		kubetypes.ConfigMirrorAnnotationKey: "mirror",
+	}
+
+	// Orphaned pods should be removed.
+	m.apiStatusVersions[testPod.UID] = 100
+	m.apiStatusVersions[mirrorPod.UID] = 200
+	m.syncBatch()
+	if _, ok := m.apiStatusVersions[testPod.UID]; ok {
+		t.Errorf("Should have cleared status for testPod")
+	}
+	if _, ok := m.apiStatusVersions[mirrorPod.UID]; ok {
+		t.Errorf("Should have cleared status for mirrorPod")
+	}
+
+	// Non-orphaned pods should not be removed.
+	m.SetPodStatus(testPod, getRandomPodStatus())
+	m.podManager.AddPod(&mirrorPod)
+	staticPod := mirrorPod
+	staticPod.UID = "static-uid"
+	staticPod.Annotations = map[string]string{kubetypes.ConfigSourceAnnotationKey: "file"}
+	m.podManager.AddPod(&staticPod)
+	m.apiStatusVersions[testPod.UID] = 100
+	m.apiStatusVersions[mirrorPod.UID] = 200
+	m.syncBatch()
+	if _, ok := m.apiStatusVersions[testPod.UID]; !ok {
+		t.Errorf("Should not have cleared status for testPod")
+	}
+	if _, ok := m.apiStatusVersions[mirrorPod.UID]; !ok {
+		t.Errorf("Should not have cleared status for mirrorPod")
+	}
+}