github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #76139 from SataQiu/fix-golint-kubectl-20190404 

Fix golint failures of pkg/kubectl/apps
k3s-v1.15.3
Kubernetes Prow Robot 2019-04-22 10:43:44 -07:00 committed by GitHub
parent cb3837f228 4c713e94d9
commit 0ca27bfee2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hack/.golint_failures
View File

@ -120,7 +120,6 @@ pkg/features
pkg/kubeapiserver
pkg/kubeapiserver/options
pkg/kubectl
pkg/kubectl/apps
pkg/kubectl/cmd/annotate
pkg/kubectl/cmd/apply
pkg/kubectl/cmd/attach

18
pkg/controller/cronjob/controller_test.go
View File

@ -153,15 +153,15 @@ func newJob(UID string) batchv1.Job {
}
var (
shortDead int64 = 10
mediumDead int64 = 2 * 60 * 60
longDead int64 = 1000000
noDead int64 = -12345
A batchV1beta1.ConcurrencyPolicy = batchV1beta1.AllowConcurrent
f batchV1beta1.ConcurrencyPolicy = batchV1beta1.ForbidConcurrent
R batchV1beta1.ConcurrencyPolicy = batchV1beta1.ReplaceConcurrent
T = true
F = false
shortDead int64 = 10
mediumDead int64 = 2 * 60 * 60
longDead int64 = 1000000
noDead int64 = -12345
A = batchV1beta1.AllowConcurrent
f = batchV1beta1.ForbidConcurrent
R = batchV1beta1.ReplaceConcurrent
T = true
F = false
)
func TestSyncOne_RunOrNot(t *testing.T) {

14
pkg/kubectl/apps/kind_visitor.go
View File

@ -73,17 +73,3 @@ func (elem GroupKindElement) GroupMatch(groups ...string) bool {
}
return false
}
// NoOpKindVisitor implements KindVisitor with no-op functions.
type NoOpKindVisitor struct{}
var _ KindVisitor = &NoOpKindVisitor{}
func (*NoOpKindVisitor) VisitDaemonSet(kind GroupKindElement) {}
func (*NoOpKindVisitor) VisitDeployment(kind GroupKindElement) {}
func (*NoOpKindVisitor) VisitJob(kind GroupKindElement) {}
func (*NoOpKindVisitor) VisitPod(kind GroupKindElement) {}
func (*NoOpKindVisitor) VisitReplicaSet(kind GroupKindElement) {}
func (*NoOpKindVisitor) VisitReplicationController(kind GroupKindElement) {}
func (*NoOpKindVisitor) VisitStatefulSet(kind GroupKindElement) {}
func (*NoOpKindVisitor) VisitCronJob(kind GroupKindElement) {}