From 80ec72685829a8e0519950b70bc3bec4ffafb19c Mon Sep 17 00:00:00 2001 From: Maciej Szulik Date: Thu, 3 Nov 2016 14:54:38 +0100 Subject: [PATCH] Fix how we iterate over active jobs when removing them for Replace policy --- pkg/controller/scheduledjob/controller.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/controller/scheduledjob/controller.go b/pkg/controller/scheduledjob/controller.go index 49a0e962e1..6dbc8e73f8 100644 --- a/pkg/controller/scheduledjob/controller.go +++ b/pkg/controller/scheduledjob/controller.go @@ -203,8 +203,7 @@ func SyncOne(sj batch.ScheduledJob, js []batch.Job, now time.Time, jc jobControl return } if sj.Spec.ConcurrencyPolicy == batch.ReplaceConcurrent { - for i := range sj.Status.Active { - j := sj.Status.Active[i] + for _, j := range sj.Status.Active { // TODO: this should be replaced with server side job deletion // currently this mimics JobReaper from pkg/kubectl/stop.go glog.V(4).Infof("Deleting job %s of %s that was still running at next scheduled start time", j.Name, nameForLog)