diff --git a/test/images/image-util.sh b/test/images/image-util.sh index 8e59188538..6d1ff49020 100755 --- a/test/images/image-util.sh +++ b/test/images/image-util.sh @@ -21,7 +21,7 @@ set -o pipefail TASK=$1 IMAGE=$2 -KUBE_ROOT="$(cd "$(dirname "${BASH_SOURCE}")/../.." && pwd -P)" +KUBE_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd -P)" source "${KUBE_ROOT}/hack/lib/util.sh" # Mapping of go ARCH to actual architectures shipped part of multiarch/qemu-user-static project @@ -29,7 +29,7 @@ declare -A QEMUARCHS=( ["amd64"]="x86_64" ["arm"]="arm" ["arm64"]="aarch64" ["pp # Returns list of all supported architectures from BASEIMAGE file listArchs() { - cut -d "=" -f 1 ${IMAGE}/BASEIMAGE + cut -d "=" -f 1 "${IMAGE}"/BASEIMAGE } # Returns baseimage need to used in Dockerfile for any given architecture @@ -56,22 +56,22 @@ build() { # Create a temporary directory for every architecture and copy the image content # and build the image from temporary directory - mkdir -p ${KUBE_ROOT}/_tmp - temp_dir=$(mktemp -d ${KUBE_ROOT}/_tmp/test-images-build.XXXXXX) + mkdir -p "${KUBE_ROOT}"/_tmp + temp_dir=$(mktemp -d "${KUBE_ROOT}"/_tmp/test-images-build.XXXXXX) kube::util::trap_add "rm -rf ${temp_dir}" EXIT - cp -r ${IMAGE}/* ${temp_dir} + cp -r "${IMAGE}"/* "${temp_dir}" if [[ -f ${IMAGE}/Makefile ]]; then # make bin will take care of all the prerequisites needed # for building the docker image - make -C ${IMAGE} bin ARCH=${arch} TARGET=${temp_dir} + make -C "${IMAGE}" bin ARCH="${arch}" TARGET="${temp_dir}" fi - pushd ${temp_dir} + pushd "${temp_dir}" # image tag TAG=$(