github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #37301 from Random-Liu/fix-remote-node-e2e-focus 

Automatic merge from submit-queue

Node E2E: Fix remote node e2e focus.

Before, we use `'focus'` and `'skip'` in `hack/make-rules/test-e2e-node.sh`.

When we run `make test-e2e-node REMOTE=true FOCUS="Some Thing"`, it will eventually be translated to `-focus='Some Thing'` [here](https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/remote/remote.go#L284-L285).

However, golang `exec.Command` wraps each argument with single quote, the argument will become `'xx -focus='Some Thing' xx'`, and cause error because of the 2 layer single quote.
pull/6/head
Kubernetes Submit Queue 2016-11-29 07:32:57 -08:00 committed by GitHub
parent e48ef45c04 1bef014c2a
commit 00aae980e8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hack/make-rules/test-e2e-node.sh
View File

@ -38,11 +38,11 @@ if [[ $parallelism > 1 ]]; then
fi fi
if [[ $focus != "" ]]; then if [[ $focus != "" ]]; then
ginkgoflags="$ginkgoflags -focus='$focus' " ginkgoflags="$ginkgoflags -focus=\"$focus\" "
fi fi
if [[ $skip != "" ]]; then if [[ $skip != "" ]]; then
ginkgoflags="$ginkgoflags -skip='$skip' " ginkgoflags="$ginkgoflags -skip=\"$skip\" "
fi fi
if [[ $run_until_failure != "" ]]; then if [[ $run_until_failure != "" ]]; then