2016-10-19 21:42:06 +00:00
|
|
|
package(default_visibility = ["//visibility:public"])
|
|
|
|
|
|
|
|
|
|
licenses(["notice"])
|
|
|
|
|
|
|
|
|
|
load(
|
|
|
|
|
"@io_bazel_rules_go//go:def.bzl",
|
|
|
|
|
"go_library",
|
|
|
|
|
"go_test",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
go_library(
|
|
|
|
|
name = "go_default_library",
|
|
|
|
|
srcs = [
|
|
|
|
|
"doc.go",
|
|
|
|
|
"horizontal.go",
|
HPA: Consider unready pods and missing metrics
Currently, the HPA considers unready pods the same as ready pods when
looking at their CPU and custom metric usage. However, pods frequently
use extra CPU during initialization, so we want to consider them
separately.
This commit causes the HPA to consider unready pods as having 0 CPU
usage when scaling up, and ignores them when scaling down. If, when
scaling up, factoring the unready pods as having 0 CPU would cause a
downscale instead, we simply choose not to scale. Otherwise, we simply
scale up at the reduced amount caculated by factoring the pods in at
zero CPU usage.
The effect is that unready pods cause the autoscaler to be a bit more
conservative -- large increases in CPU usage can still cause scales,
even with unready pods in the mix, but will not cause the scale factors
to be as large, in anticipation of the new pods later becoming ready and
handling load.
Similarly, if there are pods for which no metrics have been retrieved,
these pods are treated as having 100% of the requested metric when
scaling down, and 0% when scaling up. As above, this cannot change the
direction of the scale.
This commit also changes the HPA to ignore superfluous metrics -- as
long as metrics for all ready pods are present, the HPA we make scaling
decisions. Currently, this only works for CPU. For custom metrics, we
cannot identify which metrics go to which pods if we get superfluous
metrics, so we abort the scale.
2016-09-27 18:47:52 +00:00
|
|
|
"replica_calculator.go",
|
2016-10-19 21:42:06 +00:00
|
|
|
],
|
|
|
|
|
tags = ["automanaged"],
|
|
|
|
|
deps = [
|
|
|
|
|
"//pkg/api/resource:go_default_library",
|
2016-11-18 21:35:28 +00:00
|
|
|
"//pkg/api/v1:go_default_library",
|
|
|
|
|
"//pkg/apis/autoscaling/v1:go_default_library",
|
|
|
|
|
"//pkg/apis/extensions/v1beta1:go_default_library",
|
2016-12-03 18:57:26 +00:00
|
|
|
"//pkg/apis/meta/v1:go_default_library",
|
2016-10-19 21:42:06 +00:00
|
|
|
"//pkg/client/cache:go_default_library",
|
2016-11-18 21:35:28 +00:00
|
|
|
"//pkg/client/clientset_generated/release_1_5/typed/autoscaling/v1:go_default_library",
|
|
|
|
|
"//pkg/client/clientset_generated/release_1_5/typed/core/v1:go_default_library",
|
|
|
|
|
"//pkg/client/clientset_generated/release_1_5/typed/extensions/v1beta1:go_default_library",
|
2016-10-19 21:42:06 +00:00
|
|
|
"//pkg/client/record:go_default_library",
|
|
|
|
|
"//pkg/controller/podautoscaler/metrics:go_default_library",
|
HPA: Consider unready pods and missing metrics
Currently, the HPA considers unready pods the same as ready pods when
looking at their CPU and custom metric usage. However, pods frequently
use extra CPU during initialization, so we want to consider them
separately.
This commit causes the HPA to consider unready pods as having 0 CPU
usage when scaling up, and ignores them when scaling down. If, when
scaling up, factoring the unready pods as having 0 CPU would cause a
downscale instead, we simply choose not to scale. Otherwise, we simply
scale up at the reduced amount caculated by factoring the pods in at
zero CPU usage.
The effect is that unready pods cause the autoscaler to be a bit more
conservative -- large increases in CPU usage can still cause scales,
even with unready pods in the mix, but will not cause the scale factors
to be as large, in anticipation of the new pods later becoming ready and
handling load.
Similarly, if there are pods for which no metrics have been retrieved,
these pods are treated as having 100% of the requested metric when
scaling down, and 0% when scaling up. As above, this cannot change the
direction of the scale.
This commit also changes the HPA to ignore superfluous metrics -- as
long as metrics for all ready pods are present, the HPA we make scaling
decisions. Currently, this only works for CPU. For custom metrics, we
cannot identify which metrics go to which pods if we get superfluous
metrics, so we abort the scale.
2016-09-27 18:47:52 +00:00
|
|
|
"//pkg/labels:go_default_library",
|
2016-10-19 21:42:06 +00:00
|
|
|
"//pkg/runtime:go_default_library",
|
|
|
|
|
"//pkg/util/runtime:go_default_library",
|
HPA: Consider unready pods and missing metrics
Currently, the HPA considers unready pods the same as ready pods when
looking at their CPU and custom metric usage. However, pods frequently
use extra CPU during initialization, so we want to consider them
separately.
This commit causes the HPA to consider unready pods as having 0 CPU
usage when scaling up, and ignores them when scaling down. If, when
scaling up, factoring the unready pods as having 0 CPU would cause a
downscale instead, we simply choose not to scale. Otherwise, we simply
scale up at the reduced amount caculated by factoring the pods in at
zero CPU usage.
The effect is that unready pods cause the autoscaler to be a bit more
conservative -- large increases in CPU usage can still cause scales,
even with unready pods in the mix, but will not cause the scale factors
to be as large, in anticipation of the new pods later becoming ready and
handling load.
Similarly, if there are pods for which no metrics have been retrieved,
these pods are treated as having 100% of the requested metric when
scaling down, and 0% when scaling up. As above, this cannot change the
direction of the scale.
This commit also changes the HPA to ignore superfluous metrics -- as
long as metrics for all ready pods are present, the HPA we make scaling
decisions. Currently, this only works for CPU. For custom metrics, we
cannot identify which metrics go to which pods if we get superfluous
metrics, so we abort the scale.
2016-09-27 18:47:52 +00:00
|
|
|
"//pkg/util/sets:go_default_library",
|
2016-10-19 21:42:06 +00:00
|
|
|
"//pkg/watch:go_default_library",
|
|
|
|
|
"//vendor:github.com/golang/glog",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
go_test(
|
|
|
|
|
name = "go_default_test",
|
HPA: Consider unready pods and missing metrics
Currently, the HPA considers unready pods the same as ready pods when
looking at their CPU and custom metric usage. However, pods frequently
use extra CPU during initialization, so we want to consider them
separately.
This commit causes the HPA to consider unready pods as having 0 CPU
usage when scaling up, and ignores them when scaling down. If, when
scaling up, factoring the unready pods as having 0 CPU would cause a
downscale instead, we simply choose not to scale. Otherwise, we simply
scale up at the reduced amount caculated by factoring the pods in at
zero CPU usage.
The effect is that unready pods cause the autoscaler to be a bit more
conservative -- large increases in CPU usage can still cause scales,
even with unready pods in the mix, but will not cause the scale factors
to be as large, in anticipation of the new pods later becoming ready and
handling load.
Similarly, if there are pods for which no metrics have been retrieved,
these pods are treated as having 100% of the requested metric when
scaling down, and 0% when scaling up. As above, this cannot change the
direction of the scale.
This commit also changes the HPA to ignore superfluous metrics -- as
long as metrics for all ready pods are present, the HPA we make scaling
decisions. Currently, this only works for CPU. For custom metrics, we
cannot identify which metrics go to which pods if we get superfluous
metrics, so we abort the scale.
2016-09-27 18:47:52 +00:00
|
|
|
srcs = [
|
|
|
|
|
"horizontal_test.go",
|
|
|
|
|
"replica_calculator_test.go",
|
|
|
|
|
],
|
2016-10-19 21:42:06 +00:00
|
|
|
library = "go_default_library",
|
|
|
|
|
tags = ["automanaged"],
|
|
|
|
|
deps = [
|
|
|
|
|
"//pkg/api/resource:go_default_library",
|
2016-12-03 19:06:03 +00:00
|
|
|
"//pkg/api/unversioned:go_default_library",
|
2016-10-19 21:42:06 +00:00
|
|
|
"//pkg/api/v1:go_default_library",
|
|
|
|
|
"//pkg/apimachinery/registered:go_default_library",
|
2016-11-18 21:35:28 +00:00
|
|
|
"//pkg/apis/autoscaling/v1:go_default_library",
|
|
|
|
|
"//pkg/apis/extensions/v1beta1:go_default_library",
|
2016-12-03 18:57:26 +00:00
|
|
|
"//pkg/apis/meta/v1:go_default_library",
|
2016-11-18 21:35:28 +00:00
|
|
|
"//pkg/client/clientset_generated/release_1_5/fake:go_default_library",
|
|
|
|
|
"//pkg/client/clientset_generated/release_1_5/typed/core/v1:go_default_library",
|
2016-10-19 21:42:06 +00:00
|
|
|
"//pkg/client/record:go_default_library",
|
|
|
|
|
"//pkg/client/restclient:go_default_library",
|
|
|
|
|
"//pkg/client/testing/core:go_default_library",
|
|
|
|
|
"//pkg/controller/podautoscaler/metrics:go_default_library",
|
|
|
|
|
"//pkg/runtime:go_default_library",
|
|
|
|
|
"//pkg/watch:go_default_library",
|
|
|
|
|
"//vendor:github.com/stretchr/testify/assert",
|
HPA: Consider unready pods and missing metrics
Currently, the HPA considers unready pods the same as ready pods when
looking at their CPU and custom metric usage. However, pods frequently
use extra CPU during initialization, so we want to consider them
separately.
This commit causes the HPA to consider unready pods as having 0 CPU
usage when scaling up, and ignores them when scaling down. If, when
scaling up, factoring the unready pods as having 0 CPU would cause a
downscale instead, we simply choose not to scale. Otherwise, we simply
scale up at the reduced amount caculated by factoring the pods in at
zero CPU usage.
The effect is that unready pods cause the autoscaler to be a bit more
conservative -- large increases in CPU usage can still cause scales,
even with unready pods in the mix, but will not cause the scale factors
to be as large, in anticipation of the new pods later becoming ready and
handling load.
Similarly, if there are pods for which no metrics have been retrieved,
these pods are treated as having 100% of the requested metric when
scaling down, and 0% when scaling up. As above, this cannot change the
direction of the scale.
This commit also changes the HPA to ignore superfluous metrics -- as
long as metrics for all ready pods are present, the HPA we make scaling
decisions. Currently, this only works for CPU. For custom metrics, we
cannot identify which metrics go to which pods if we get superfluous
metrics, so we abort the scale.
2016-09-27 18:47:52 +00:00
|
|
|
"//vendor:github.com/stretchr/testify/require",
|
2016-10-19 21:42:06 +00:00
|
|
|
"//vendor:k8s.io/heapster/metrics/api/v1/types",
|
|
|
|
|
"//vendor:k8s.io/heapster/metrics/apis/metrics/v1alpha1",
|
|
|
|
|
],
|
|
|
|
|
)
|