2014-07-31 19:02:49 +00:00
|
|
|
/*
|
|
|
|
Copyright 2014 Google Inc. All rights reserved.
|
|
|
|
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
you may not use this file except in compliance with the License.
|
|
|
|
You may obtain a copy of the License at
|
|
|
|
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
See the License for the specific language governing permissions and
|
|
|
|
limitations under the License.
|
|
|
|
*/
|
|
|
|
|
|
|
|
package conversion
|
|
|
|
|
|
|
|
import (
|
|
|
|
"encoding/json"
|
|
|
|
"flag"
|
|
|
|
"fmt"
|
|
|
|
"reflect"
|
|
|
|
"testing"
|
|
|
|
|
|
|
|
"github.com/GoogleCloudPlatform/kubernetes/pkg/util"
|
2014-08-08 22:45:51 +00:00
|
|
|
"github.com/google/gofuzz"
|
2014-07-31 19:02:49 +00:00
|
|
|
)
|
|
|
|
|
2014-08-08 22:45:51 +00:00
|
|
|
var fuzzIters = flag.Int("fuzz_iters", 50, "How many fuzzing iterations to do.")
|
2014-07-31 19:02:49 +00:00
|
|
|
|
2014-08-01 21:24:12 +00:00
|
|
|
// Test a weird version/kind embedding format.
|
|
|
|
type MyWeirdCustomEmbeddedVersionKindField struct {
|
2014-07-31 19:02:49 +00:00
|
|
|
ID string `yaml:"ID,omitempty" json:"ID,omitempty"`
|
2014-08-01 21:24:12 +00:00
|
|
|
APIVersion string `json:"myVersionKey,omitempty" yaml:"myVersionKey,omitempty"`
|
|
|
|
ObjectKind string `json:"myKindKey,omitempty" yaml:"myKindKey,omitempty"`
|
|
|
|
Z string `yaml:"Z,omitempty" json:"Z,omitempty"`
|
|
|
|
Y uint64 `yaml:"Y,omitempty" json:"Y,omitempty"`
|
2014-07-31 19:02:49 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
type TestType1 struct {
|
2014-08-01 21:24:12 +00:00
|
|
|
MyWeirdCustomEmbeddedVersionKindField `json:",inline" yaml:",inline"`
|
|
|
|
A string `yaml:"A,omitempty" json:"A,omitempty"`
|
|
|
|
B int `yaml:"B,omitempty" json:"B,omitempty"`
|
|
|
|
C int8 `yaml:"C,omitempty" json:"C,omitempty"`
|
|
|
|
D int16 `yaml:"D,omitempty" json:"D,omitempty"`
|
|
|
|
E int32 `yaml:"E,omitempty" json:"E,omitempty"`
|
|
|
|
F int64 `yaml:"F,omitempty" json:"F,omitempty"`
|
|
|
|
G uint `yaml:"G,omitempty" json:"G,omitempty"`
|
|
|
|
H uint8 `yaml:"H,omitempty" json:"H,omitempty"`
|
|
|
|
I uint16 `yaml:"I,omitempty" json:"I,omitempty"`
|
|
|
|
J uint32 `yaml:"J,omitempty" json:"J,omitempty"`
|
|
|
|
K uint64 `yaml:"K,omitempty" json:"K,omitempty"`
|
|
|
|
L bool `yaml:"L,omitempty" json:"L,omitempty"`
|
|
|
|
M map[string]int `yaml:"M,omitempty" json:"M,omitempty"`
|
|
|
|
N map[string]TestType2 `yaml:"N,omitempty" json:"N,omitempty"`
|
|
|
|
O *TestType2 `yaml:"O,omitempty" json:"O,omitempty"`
|
|
|
|
P []TestType2 `yaml:"Q,omitempty" json:"Q,omitempty"`
|
2014-07-31 19:02:49 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
type TestType2 struct {
|
|
|
|
A string `yaml:"A,omitempty" json:"A,omitempty"`
|
|
|
|
B int `yaml:"B,omitempty" json:"B,omitempty"`
|
|
|
|
}
|
|
|
|
|
|
|
|
// We depend on the name of the external and internal types matching. Ordinarily,
|
|
|
|
// we'd accomplish this with an additional package, but since this is a test, we
|
|
|
|
// can just enclose stuff in a function to simulate that.
|
|
|
|
func externalTypeReturn() interface{} {
|
|
|
|
type TestType2 struct {
|
|
|
|
A string `yaml:"A,omitempty" json:"A,omitempty"`
|
|
|
|
B int `yaml:"B,omitempty" json:"B,omitempty"`
|
|
|
|
}
|
|
|
|
type TestType1 struct {
|
2014-08-01 21:24:12 +00:00
|
|
|
MyWeirdCustomEmbeddedVersionKindField `json:",inline" yaml:",inline"`
|
|
|
|
A string `yaml:"A,omitempty" json:"A,omitempty"`
|
|
|
|
B int `yaml:"B,omitempty" json:"B,omitempty"`
|
|
|
|
C int8 `yaml:"C,omitempty" json:"C,omitempty"`
|
|
|
|
D int16 `yaml:"D,omitempty" json:"D,omitempty"`
|
|
|
|
E int32 `yaml:"E,omitempty" json:"E,omitempty"`
|
|
|
|
F int64 `yaml:"F,omitempty" json:"F,omitempty"`
|
|
|
|
G uint `yaml:"G,omitempty" json:"G,omitempty"`
|
|
|
|
H uint8 `yaml:"H,omitempty" json:"H,omitempty"`
|
|
|
|
I uint16 `yaml:"I,omitempty" json:"I,omitempty"`
|
|
|
|
J uint32 `yaml:"J,omitempty" json:"J,omitempty"`
|
|
|
|
K uint64 `yaml:"K,omitempty" json:"K,omitempty"`
|
|
|
|
L bool `yaml:"L,omitempty" json:"L,omitempty"`
|
|
|
|
M map[string]int `yaml:"M,omitempty" json:"M,omitempty"`
|
|
|
|
N map[string]TestType2 `yaml:"N,omitempty" json:"N,omitempty"`
|
|
|
|
O *TestType2 `yaml:"O,omitempty" json:"O,omitempty"`
|
|
|
|
P []TestType2 `yaml:"Q,omitempty" json:"Q,omitempty"`
|
2014-07-31 19:02:49 +00:00
|
|
|
}
|
2014-09-05 22:20:59 +00:00
|
|
|
return &TestType1{}
|
2014-07-31 19:02:49 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
type ExternalInternalSame struct {
|
2014-08-01 21:24:12 +00:00
|
|
|
MyWeirdCustomEmbeddedVersionKindField `json:",inline" yaml:",inline"`
|
|
|
|
A TestType2 `yaml:"A,omitempty" json:"A,omitempty"`
|
2014-07-31 19:02:49 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// TestObjectFuzzer can randomly populate all the above objects.
|
2014-08-08 22:45:51 +00:00
|
|
|
var TestObjectFuzzer = fuzz.New().NilChance(.5).NumElements(1, 100).Funcs(
|
|
|
|
func(j *MyWeirdCustomEmbeddedVersionKindField, c fuzz.Continue) {
|
2014-08-01 21:24:12 +00:00
|
|
|
// We have to customize the randomization of MyWeirdCustomEmbeddedVersionKindFields because their
|
2014-07-31 19:02:49 +00:00
|
|
|
// APIVersion and Kind must remain blank in memory.
|
|
|
|
j.APIVersion = ""
|
2014-08-01 21:24:12 +00:00
|
|
|
j.ObjectKind = ""
|
2014-08-08 22:45:51 +00:00
|
|
|
j.ID = c.RandString()
|
2014-07-31 19:02:49 +00:00
|
|
|
},
|
2014-08-08 22:45:51 +00:00
|
|
|
func(u *uint64, c fuzz.Continue) {
|
2014-07-31 19:02:49 +00:00
|
|
|
// TODO: Fix JSON/YAML packages and/or write custom encoding
|
|
|
|
// for uint64's. Somehow the LS *byte* of this is lost, but
|
|
|
|
// only when all 8 bytes are set.
|
2014-08-08 22:45:51 +00:00
|
|
|
*u = c.RandUint64() >> 8
|
2014-07-31 19:02:49 +00:00
|
|
|
},
|
2014-08-08 22:45:51 +00:00
|
|
|
func(u *uint, c fuzz.Continue) {
|
2014-07-31 19:02:49 +00:00
|
|
|
// TODO: Fix JSON/YAML packages and/or write custom encoding
|
|
|
|
// for uint64's. Somehow the LS *byte* of this is lost, but
|
|
|
|
// only when all 8 bytes are set.
|
2014-08-08 22:45:51 +00:00
|
|
|
*u = uint(c.RandUint64() >> 8)
|
2014-07-31 19:02:49 +00:00
|
|
|
},
|
|
|
|
)
|
|
|
|
|
|
|
|
// Returns a new Scheme set up with the test objects.
|
|
|
|
func GetTestScheme() *Scheme {
|
|
|
|
s := NewScheme()
|
2014-09-05 22:20:59 +00:00
|
|
|
s.AddKnownTypes("", &TestType1{}, &ExternalInternalSame{})
|
|
|
|
s.AddKnownTypes("v1", externalTypeReturn(), &ExternalInternalSame{})
|
2014-07-31 19:02:49 +00:00
|
|
|
s.ExternalVersion = "v1"
|
|
|
|
s.InternalVersion = ""
|
2014-08-01 21:24:12 +00:00
|
|
|
s.MetaInsertionFactory = testMetaInsertionFactory{}
|
2014-07-31 19:02:49 +00:00
|
|
|
return s
|
|
|
|
}
|
|
|
|
|
2014-08-01 21:24:12 +00:00
|
|
|
type testMetaInsertionFactory struct {
|
|
|
|
MyWeirdCustomEmbeddedVersionKindField struct {
|
|
|
|
APIVersion string `json:"myVersionKey,omitempty" yaml:"myVersionKey,omitempty"`
|
|
|
|
ObjectKind string `json:"myKindKey,omitempty" yaml:"myKindKey,omitempty"`
|
|
|
|
} `json:",inline" yaml:",inline"`
|
|
|
|
}
|
|
|
|
|
|
|
|
// Create returns a new testMetaInsertionFactory with the version and kind fields set.
|
|
|
|
func (testMetaInsertionFactory) Create(version, kind string) interface{} {
|
|
|
|
m := testMetaInsertionFactory{}
|
|
|
|
m.MyWeirdCustomEmbeddedVersionKindField.APIVersion = version
|
|
|
|
m.MyWeirdCustomEmbeddedVersionKindField.ObjectKind = kind
|
|
|
|
return &m
|
|
|
|
}
|
|
|
|
|
|
|
|
// Interpret returns the version and kind information from in, which must be
|
|
|
|
// a testMetaInsertionFactory pointer object.
|
|
|
|
func (testMetaInsertionFactory) Interpret(in interface{}) (version, kind string) {
|
|
|
|
m := in.(*testMetaInsertionFactory)
|
|
|
|
return m.MyWeirdCustomEmbeddedVersionKindField.APIVersion, m.MyWeirdCustomEmbeddedVersionKindField.ObjectKind
|
|
|
|
}
|
|
|
|
|
2014-07-31 19:02:49 +00:00
|
|
|
func objDiff(a, b interface{}) string {
|
|
|
|
ab, err := json.Marshal(a)
|
|
|
|
if err != nil {
|
|
|
|
panic("a")
|
|
|
|
}
|
|
|
|
bb, err := json.Marshal(b)
|
|
|
|
if err != nil {
|
|
|
|
panic("b")
|
|
|
|
}
|
|
|
|
return util.StringDiff(string(ab), string(bb))
|
|
|
|
|
|
|
|
// An alternate diff attempt, in case json isn't showing you
|
|
|
|
// the difference. (reflect.DeepEqual makes a distinction between
|
|
|
|
// nil and empty slices, for example.)
|
|
|
|
return util.StringDiff(
|
|
|
|
fmt.Sprintf("%#v", a),
|
|
|
|
fmt.Sprintf("%#v", b),
|
|
|
|
)
|
|
|
|
}
|
|
|
|
|
|
|
|
func runTest(t *testing.T, source interface{}) {
|
|
|
|
name := reflect.TypeOf(source).Elem().Name()
|
|
|
|
TestObjectFuzzer.Fuzz(source)
|
|
|
|
|
|
|
|
s := GetTestScheme()
|
|
|
|
data, err := s.Encode(source)
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("%v: %v (%#v)", name, err, source)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
obj2, err := s.Decode(data)
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("%v: %v (%v)", name, err, string(data))
|
|
|
|
return
|
2014-08-01 21:24:12 +00:00
|
|
|
}
|
|
|
|
if !reflect.DeepEqual(source, obj2) {
|
|
|
|
t.Errorf("1: %v: diff: %v", name, objDiff(source, obj2))
|
|
|
|
return
|
2014-07-31 19:02:49 +00:00
|
|
|
}
|
|
|
|
obj3 := reflect.New(reflect.TypeOf(source).Elem()).Interface()
|
|
|
|
err = s.DecodeInto(data, obj3)
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("2: %v: %v", name, err)
|
|
|
|
return
|
2014-08-01 21:24:12 +00:00
|
|
|
}
|
|
|
|
if !reflect.DeepEqual(source, obj3) {
|
|
|
|
t.Errorf("3: %v: diff: %v", name, objDiff(source, obj3))
|
|
|
|
return
|
2014-07-31 19:02:49 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestTypes(t *testing.T) {
|
|
|
|
table := []interface{}{
|
|
|
|
&TestType1{},
|
|
|
|
&ExternalInternalSame{},
|
|
|
|
}
|
|
|
|
for _, item := range table {
|
|
|
|
// Try a few times, since runTest uses random values.
|
|
|
|
for i := 0; i < *fuzzIters; i++ {
|
|
|
|
runTest(t, item)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestEncode_NonPtr(t *testing.T) {
|
|
|
|
s := GetTestScheme()
|
|
|
|
tt := TestType1{A: "I'm not a pointer object"}
|
|
|
|
obj := interface{}(tt)
|
|
|
|
data, err := s.Encode(obj)
|
|
|
|
obj2, err2 := s.Decode(data)
|
|
|
|
if err != nil || err2 != nil {
|
|
|
|
t.Fatalf("Failure: '%v' '%v'", err, err2)
|
|
|
|
}
|
|
|
|
if _, ok := obj2.(*TestType1); !ok {
|
|
|
|
t.Fatalf("Got wrong type")
|
|
|
|
}
|
|
|
|
if !reflect.DeepEqual(obj2, &tt) {
|
|
|
|
t.Errorf("Expected:\n %#v,\n Got:\n %#v", &tt, obj2)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestEncode_Ptr(t *testing.T) {
|
|
|
|
s := GetTestScheme()
|
|
|
|
tt := &TestType1{A: "I am a pointer object"}
|
|
|
|
obj := interface{}(tt)
|
|
|
|
data, err := s.Encode(obj)
|
|
|
|
obj2, err2 := s.Decode(data)
|
|
|
|
if err != nil || err2 != nil {
|
|
|
|
t.Fatalf("Failure: '%v' '%v'", err, err2)
|
|
|
|
}
|
|
|
|
if _, ok := obj2.(*TestType1); !ok {
|
|
|
|
t.Fatalf("Got wrong type")
|
|
|
|
}
|
|
|
|
if !reflect.DeepEqual(obj2, tt) {
|
|
|
|
t.Errorf("Expected:\n %#v,\n Got:\n %#v", &tt, obj2)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestBadJSONRejection(t *testing.T) {
|
|
|
|
s := GetTestScheme()
|
|
|
|
badJSONs := [][]byte{
|
2014-08-01 21:24:12 +00:00
|
|
|
[]byte(`{"myVersionKey":"v1"}`), // Missing kind
|
|
|
|
[]byte(`{"myKindKey":"TestType1"}`), // Missing version
|
|
|
|
[]byte(`{"myVersionKey":"v1","myKindKey":"bar"}`), // Unknown kind
|
|
|
|
[]byte(`{"myVersionKey":"bar","myKindKey":"TestType1"}`), // Unknown version
|
2014-07-31 19:02:49 +00:00
|
|
|
}
|
|
|
|
for _, b := range badJSONs {
|
|
|
|
if _, err := s.Decode(b); err == nil {
|
|
|
|
t.Errorf("Did not reject bad json: %s", string(b))
|
|
|
|
}
|
|
|
|
}
|
2014-08-01 21:24:12 +00:00
|
|
|
badJSONKindMismatch := []byte(`{"myVersionKey":"v1","myKindKey":"ExternalInternalSame"}`)
|
2014-07-31 19:02:49 +00:00
|
|
|
if err := s.DecodeInto(badJSONKindMismatch, &TestType1{}); err == nil {
|
|
|
|
t.Errorf("Kind is set but doesn't match the object type: %s", badJSONKindMismatch)
|
|
|
|
}
|
|
|
|
}
|