2018-08-29 14:39:01 +00:00
|
|
|
/*
|
|
|
|
|
Copyright 2018 The Kubernetes Authors.
|
|
|
|
|
|
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
|
you may not use this file except in compliance with the License.
|
|
|
|
|
You may obtain a copy of the License at
|
|
|
|
|
|
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
|
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
|
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
|
See the License for the specific language governing permissions and
|
|
|
|
|
limitations under the License.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
package storage
|
|
|
|
|
|
|
|
|
|
import (
|
2019-05-10 05:56:26 +00:00
|
|
|
"github.com/onsi/ginkgo"
|
2018-08-29 14:39:01 +00:00
|
|
|
"k8s.io/kubernetes/test/e2e/storage/drivers"
|
|
|
|
|
"k8s.io/kubernetes/test/e2e/storage/testsuites"
|
|
|
|
|
"k8s.io/kubernetes/test/e2e/storage/utils"
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
// List of testDrivers to be executed in below loop
|
e2e/storage: speed up skipping, simplify APIs and test definition
CreateDriver (now called SetupTest) is a potentially expensive
operation, depending on the driver. Creating and tearing down a
framework instance also takes time (measured at 6 seconds on a fast
machine) and produces quite a bit of log output.
Both can be avoided for tests that skip based on static
information (like for instance the current OS, vendor, driver and test
pattern) by making the test suite responsible for creating framework
and driver.
The lifecycle of the TestConfig instance was confusing because it was
stored inside the DriverInfo, a struct which conceptually is static,
while the TestConfig is dynamic. It is cleaner to separate the two,
even if that means that an additional pointer must be passed into some
functions. Now CreateDriver is responsible for initializing the
PerTestConfig that is to be used by the test.
To make this approach simpler to implement (= less functions which
need the pointer) and the tests easier to read, the entire setup and
test definition is now contained in a single function. This is how it
is normally done in Ginkgo. This is easier to read because one can see
at a glance where variables are set, instead of having to trace values
though two additional structs (TestResource and TestInput).
Because we are changing the API already, also other changes are made:
- some function prototypes get simplified
- the naming of functions is changed to match their purpose
(tests aren't executed by the test suite, they only get defined
for later execution)
- unused methods get removed (TestSuite.skipUnsupportedTest is redundant)
2018-12-29 16:08:34 +00:00
|
|
|
var testDrivers = []func() testsuites.TestDriver{
|
2018-08-29 14:39:01 +00:00
|
|
|
drivers.InitNFSDriver,
|
|
|
|
|
drivers.InitGlusterFSDriver,
|
|
|
|
|
drivers.InitISCSIDriver,
|
|
|
|
|
drivers.InitRbdDriver,
|
|
|
|
|
drivers.InitCephFSDriver,
|
2018-08-30 22:53:59 +00:00
|
|
|
drivers.InitHostPathDriver,
|
|
|
|
|
drivers.InitHostPathSymlinkDriver,
|
2018-08-29 14:39:01 +00:00
|
|
|
drivers.InitEmptydirDriver,
|
|
|
|
|
drivers.InitCinderDriver,
|
2018-08-30 19:30:23 +00:00
|
|
|
drivers.InitGcePdDriver,
|
2018-08-29 14:39:01 +00:00
|
|
|
drivers.InitVSphereDriver,
|
|
|
|
|
drivers.InitAzureDriver,
|
|
|
|
|
drivers.InitAwsDriver,
|
2019-01-30 10:58:24 +00:00
|
|
|
drivers.InitLocalDriverWithVolumeType(utils.LocalVolumeDirectory),
|
|
|
|
|
drivers.InitLocalDriverWithVolumeType(utils.LocalVolumeDirectoryLink),
|
|
|
|
|
drivers.InitLocalDriverWithVolumeType(utils.LocalVolumeDirectoryBindMounted),
|
|
|
|
|
drivers.InitLocalDriverWithVolumeType(utils.LocalVolumeDirectoryLinkBindMounted),
|
|
|
|
|
drivers.InitLocalDriverWithVolumeType(utils.LocalVolumeTmpfs),
|
|
|
|
|
drivers.InitLocalDriverWithVolumeType(utils.LocalVolumeBlock),
|
|
|
|
|
drivers.InitLocalDriverWithVolumeType(utils.LocalVolumeBlockFS),
|
|
|
|
|
drivers.InitLocalDriverWithVolumeType(utils.LocalVolumeGCELocalSSD),
|
2018-08-29 14:39:01 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// List of testSuites to be executed in below loop
|
|
|
|
|
var testSuites = []func() testsuites.TestSuite{
|
|
|
|
|
testsuites.InitVolumesTestSuite,
|
|
|
|
|
testsuites.InitVolumeIOTestSuite,
|
|
|
|
|
testsuites.InitVolumeModeTestSuite,
|
|
|
|
|
testsuites.InitSubPathTestSuite,
|
2018-10-22 16:04:43 +00:00
|
|
|
testsuites.InitProvisioningTestSuite,
|
2019-02-28 01:31:37 +00:00
|
|
|
testsuites.InitMultiVolumeTestSuite,
|
2018-08-29 14:39:01 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// This executes testSuites for in-tree volumes.
|
|
|
|
|
var _ = utils.SIGDescribe("In-tree Volumes", func() {
|
|
|
|
|
for _, initDriver := range testDrivers {
|
e2e/storage: speed up skipping, simplify APIs and test definition
CreateDriver (now called SetupTest) is a potentially expensive
operation, depending on the driver. Creating and tearing down a
framework instance also takes time (measured at 6 seconds on a fast
machine) and produces quite a bit of log output.
Both can be avoided for tests that skip based on static
information (like for instance the current OS, vendor, driver and test
pattern) by making the test suite responsible for creating framework
and driver.
The lifecycle of the TestConfig instance was confusing because it was
stored inside the DriverInfo, a struct which conceptually is static,
while the TestConfig is dynamic. It is cleaner to separate the two,
even if that means that an additional pointer must be passed into some
functions. Now CreateDriver is responsible for initializing the
PerTestConfig that is to be used by the test.
To make this approach simpler to implement (= less functions which
need the pointer) and the tests easier to read, the entire setup and
test definition is now contained in a single function. This is how it
is normally done in Ginkgo. This is easier to read because one can see
at a glance where variables are set, instead of having to trace values
though two additional structs (TestResource and TestInput).
Because we are changing the API already, also other changes are made:
- some function prototypes get simplified
- the naming of functions is changed to match their purpose
(tests aren't executed by the test suite, they only get defined
for later execution)
- unused methods get removed (TestSuite.skipUnsupportedTest is redundant)
2018-12-29 16:08:34 +00:00
|
|
|
curDriver := initDriver()
|
2018-12-28 16:41:45 +00:00
|
|
|
|
2019-05-10 05:56:26 +00:00
|
|
|
ginkgo.Context(testsuites.GetDriverNameWithFeatureTags(curDriver), func() {
|
2019-02-13 19:46:49 +00:00
|
|
|
testsuites.DefineTestSuite(curDriver, testSuites)
|
2018-08-29 14:39:01 +00:00
|
|
|
})
|
|
|
|
|
}
|
|
|
|
|
})
|