github
/
jumpserver
mirror of https://github.com/jumpserver/jumpserver
1
0
Fork 0
Code Issues Releases Wiki Activity

perf: 优化 saml

pull/7404/head
ibuler 2021-12-15 19:53:30 +08:00 committed by Jiangjie.Bai
parent 93d77b2312
commit eb3165f8e7
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
apps/authentication/backends/saml2/views.py
View File

@ -270,7 +270,7 @@ class Saml2AuthCallbackView(View, PrepareRequestMixin):
class Saml2AuthMetadataView(View, PrepareRequestMixin): class Saml2AuthMetadataView(View, PrepareRequestMixin):
def get(self, _): def get(self, request):
saml_settings = self.get_sp_settings() saml_settings = self.get_sp_settings()
saml_settings = JmsSaml2Settings( saml_settings = JmsSaml2Settings(
settings=saml_settings, sp_validation_only=True, settings=saml_settings, sp_validation_only=True,
@ -279,8 +279,17 @@ class Saml2AuthMetadataView(View, PrepareRequestMixin):
metadata = saml_settings.get_sp_metadata() metadata = saml_settings.get_sp_metadata()
errors = saml_settings.validate_metadata(metadata) errors = saml_settings.validate_metadata(metadata)
key = saml_settings.get_sp_key()
cert = saml_settings.get_sp_cert()
if not key:
errors.append('Not found SP private key')
if not cert:
errors.append('Not found SP cert')
if len(errors) == 0: if len(errors) == 0:
resp = HttpResponse(content=metadata, content_type='text/xml') resp = HttpResponse(content=metadata, content_type='text/xml')
else: else:
resp = HttpResponseServerError(content=', '.join(errors)) content = "Error occur: <br>"
content += '<br>'.join(errors)
resp = HttpResponseServerError(content=content)
return resp return resp