From e84411588a6ee4c219d22f9d57581537d1dbcbc3 Mon Sep 17 00:00:00 2001 From: fit2bot <68588906+fit2bot@users.noreply.github.com> Date: Thu, 16 Feb 2023 15:36:54 +0800 Subject: [PATCH] =?UTF-8?q?fix:=20=E8=A7=A3=E5=86=B3playbook=20=E4=B8=8A?= =?UTF-8?q?=E4=BC=A0500=E7=9A=84=E9=97=AE=E9=A2=98=20(#9580)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Aaron3S --- apps/ops/serializers/playbook.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/apps/ops/serializers/playbook.py b/apps/ops/serializers/playbook.py index 3429766d5..cc9132013 100644 --- a/apps/ops/serializers/playbook.py +++ b/apps/ops/serializers/playbook.py @@ -5,6 +5,7 @@ from rest_framework import serializers from common.serializers.fields import ReadableHiddenField from ops.models import Playbook from orgs.mixins.serializers import BulkOrgResourceModelSerializer +from django.utils.translation import gettext_lazy as _ def parse_playbook_name(path): @@ -15,13 +16,13 @@ def parse_playbook_name(path): class PlaybookSerializer(BulkOrgResourceModelSerializer): creator = ReadableHiddenField(default=serializers.CurrentUserDefault()) path = serializers.FileField(required=False) + name = serializers.CharField(label=_('Name'), max_length=128, allow_blank=True, required=False) - def create(self, validated_data): - name = validated_data.get('name') + def to_internal_value(self, data): + name = data.get('name', False) if not name: - path = validated_data.get('path').name - validated_data['name'] = parse_playbook_name(path) - return super().create(validated_data) + data['name'] = parse_playbook_name(data['path'].name) + return super().to_internal_value(data) class Meta: model = Playbook