perf: rdp file添加domain

fix: 禁用的用户不返回信息

perf: 优化token,禁用的资产无法链接
pull/6250/head
ibuler 4 years ago committed by 老广
parent d6527e3b02
commit de6908e5a6

@ -10,6 +10,7 @@ from rest_framework.response import Response
from rest_framework.viewsets import GenericViewSet from rest_framework.viewsets import GenericViewSet
from rest_framework.decorators import action from rest_framework.decorators import action
from rest_framework.exceptions import PermissionDenied from rest_framework.exceptions import PermissionDenied
from rest_framework import serializers
from common.utils import get_logger, random_string from common.utils import get_logger, random_string
from common.drf.api import SerializerMixin2 from common.drf.api import SerializerMixin2
@ -120,7 +121,8 @@ class UserConnectionTokenViewSet(RootOrgViewMixin, SerializerMixin2, GenericView
'autoreconnection enabled:i': '1', 'autoreconnection enabled:i': '1',
'bookmarktype:i': '3', 'bookmarktype:i': '3',
'use redirection server name:i': '0', 'use redirection server name:i': '0',
'smart sizing:i': '0' 'smart sizing:i': '0',
# 'domain:s': ''
# 'alternate shell:s:': '||MySQLWorkbench', # 'alternate shell:s:': '||MySQLWorkbench',
# 'remoteapplicationname:s': 'Firefox', # 'remoteapplicationname:s': 'Firefox',
# 'remoteapplicationcmdline:s': '', # 'remoteapplicationcmdline:s': '',
@ -140,12 +142,13 @@ class UserConnectionTokenViewSet(RootOrgViewMixin, SerializerMixin2, GenericView
user = request.user user = request.user
token = self.create_token(user, asset, application, system_user) token = self.create_token(user, asset, application, system_user)
# Todo: 上线后地址是 JumpServerAddr:3389
address = settings.TERMINAL_RDP_ADDR address = settings.TERMINAL_RDP_ADDR
if not address or address == 'localhost:3389': if not address or address == 'localhost:3389':
address = request.get_host().split(':')[0] + ':3389' address = request.get_host().split(':')[0] + ':3389'
options['full address:s'] = address options['full address:s'] = address
options['username:s'] = '{}|{}'.format(user.username, token) options['username:s'] = '{}|{}'.format(user.username, token)
if system_user.ad_domain:
options['domain:s'] = system_user.ad_domain
if width and height: if width and height:
options['desktopwidth:i'] = width options['desktopwidth:i'] = width
options['desktopheight:i'] = height options['desktopheight:i'] = height
@ -161,10 +164,9 @@ class UserConnectionTokenViewSet(RootOrgViewMixin, SerializerMixin2, GenericView
return response return response
@staticmethod @staticmethod
def _get_application_secret_detail(value): def _get_application_secret_detail(application):
from applications.models import Application from applications.models import Application
from perms.models import Action from perms.models import Action
application = get_object_or_404(Application, id=value.get('application'))
gateway = None gateway = None
if not application.category_remote_app: if not application.category_remote_app:
@ -190,15 +192,15 @@ class UserConnectionTokenViewSet(RootOrgViewMixin, SerializerMixin2, GenericView
} }
@staticmethod @staticmethod
def _get_asset_secret_detail(value, user, system_user): def _get_asset_secret_detail(asset, user, system_user):
from assets.models import Asset
from perms.utils.asset import get_asset_system_user_ids_with_actions_by_user from perms.utils.asset import get_asset_system_user_ids_with_actions_by_user
asset = get_object_or_404(Asset, id=value.get('asset'))
systemuserid_actions_mapper = get_asset_system_user_ids_with_actions_by_user(user, asset) systemuserid_actions_mapper = get_asset_system_user_ids_with_actions_by_user(user, asset)
actions = systemuserid_actions_mapper.get(system_user.id, []) actions = systemuserid_actions_mapper.get(system_user.id, [])
gateway = None gateway = None
if asset and asset.domain and asset.domain.has_gateway(): if asset and asset.domain and asset.domain.has_gateway():
gateway = asset.domain.random_gateway() gateway = asset.domain.random_gateway()
return { return {
'asset': asset, 'asset': asset,
'application': None, 'application': None,
@ -207,32 +209,49 @@ class UserConnectionTokenViewSet(RootOrgViewMixin, SerializerMixin2, GenericView
'actions': actions, 'actions': actions,
} }
@action(methods=['POST'], detail=False, permission_classes=[IsSuperUserOrAppUser], url_path='secret-info/detail') def valid_token(self, token):
def get_secret_detail(self, request, *args, **kwargs):
from users.models import User from users.models import User
from assets.models import SystemUser from assets.models import SystemUser, Asset
from applications.models import Application
token = request.data.get('token', '')
key = self.CACHE_KEY_PREFIX.format(token) key = self.CACHE_KEY_PREFIX.format(token)
value = cache.get(key, None) value = cache.get(key, None)
if not value: if not value:
return Response(status=404) raise serializers.ValidationError('Token not found')
user = get_object_or_404(User, id=value.get('user')) user = get_object_or_404(User, id=value.get('user'))
if user.is_valid:
raise serializers.ValidationError("User not valid, disabled or expired")
system_user = get_object_or_404(SystemUser, id=value.get('system_user')) system_user = get_object_or_404(SystemUser, id=value.get('system_user'))
data = dict(user=user, system_user=system_user) if system_user.ad_domain:
system_user.username = '{0.username}@{0.ad_domain}'.format(system_user)
asset = None
app = None
if value.get('type') == 'asset': if value.get('type') == 'asset':
asset_detail = self._get_asset_secret_detail(value, user=user, system_user=system_user) asset = get_object_or_404(Asset, id=value.get('asset'))
asset = asset_detail.get('asset') else:
if asset: app = get_object_or_404(Application, id=value.get('application'))
system_user.load_asset_more_auth(asset.id, user.username, user.id)
if asset and not asset.is_active:
raise serializers.ValidationError("Asset disabled")
return value, user, system_user, asset, app
@action(methods=['POST'], detail=False, permission_classes=[IsSuperUserOrAppUser], url_path='secret-info/detail')
def get_secret_detail(self, request, *args, **kwargs):
token = request.data.get('token', '')
value, user, system_user, asset, app = self.valid_token(token)
data = dict(user=user, system_user=system_user)
if asset:
asset_detail = self._get_asset_secret_detail(asset, user=user, system_user=system_user)
system_user.load_asset_more_auth(asset.id, user.username, user.id)
data['type'] = 'asset' data['type'] = 'asset'
data.update(asset_detail) data.update(asset_detail)
else: else:
app_detail = self._get_application_secret_detail(value) app_detail = self._get_application_secret_detail(app)
app = app_detail.get("application") system_user.load_app_more_auth(app.id, user.id)
if app:
system_user.load_app_more_auth(app.id, user.id)
data['type'] = 'application' data['type'] = 'application'
data.update(app_detail) data.update(app_detail)

Loading…
Cancel
Save